Llewellyn/Tomb
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/Tomb.git synced 2024-09-24 18:59:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

tomb forge: useless sudo and chown

Browse Source 
Depending script invokation, behavior is not exactly similar.
Assuming that if SUDO_USER is set, the _sudo invokation can be dropped (EUID=0).
In the other case, user has created file, owner is already good, don't call chown.

Preparation:
$ tomb dig foo.tomb -s 10

Method 1:
$ sudo tomb forge foo.tomb.key -v

Method 2:
$ tomb forge foo.tomb.key -v
... ask user password to gain superuser privileges
...
Sorry, user <username> is not allowed to execute '/bin/chown <uid>:<gid> foo.tomb.key' as root on <hostname>.

Signed-off-by: Matthieu Crapet <mcrapet@gmail.com>
This commit is contained in:
Matthieu Crapet 2021-01-01 21:46:11 +01:00
parent 99f10bf215
commit 02812f4c06
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tomb
View File

@ -1955,7 +1955,7 @@ forge_key() {
_failure "Operation aborted." _failure "Operation aborted."
} }
_sudo chown ${_UID}:${_GID} "$TOMBKEYFILE" [[ -n $SUDO_USER ]] && chown ${_UID}:${_GID} "$TOMBKEYFILE"
_message "Done forging ::1 key file::" $TOMBKEYFILE _message "Done forging ::1 key file::" $TOMBKEYFILE
_success "Your key is ready:" _success "Your key is ready:"
ls -lh $TOMBKEYFILE ls -lh $TOMBKEYFILE