Llewellyn/conky
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/conky.git synced 2024-11-17 10:35:10 +00:00
Code Issues Releases Activity

Fix an out-of-range error in new_graph (#356)

Browse Source 
The code was multiplying the index with the size of the element, and
then adding it to the typed pointer (resulting in a double
multiplication and an OOB access).

Replace the buggy code with a slightly safer c++ alternative.
This commit is contained in:
labath 2017-01-31 01:31:09 +00:00 committed by Brenden Matthews
parent 641f4ecfdb
commit 2600d01373
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/specials.cc
View File

@ -519,14 +519,12 @@ void new_graph(struct text_object *obj, char *buf, int buf_max_size, double val)
DBGP("reallocing graph from %d to %d", s->graph_allocated, s->graph_width);
if (!s->graph) {
/* initialize */
memset(graph, 0, s->graph_width * sizeof(double));
std::fill_n(graph, s->graph_width, 0.0);
s->scale = 100;
} else {
if (s->graph_width > s->graph_allocated) {
/* initialize the new region */
memset(graph + (s->graph_allocated * sizeof(double)), 0,
(s->graph_width - s->graph_allocated) *
sizeof(double));
std::fill(graph + s->graph_allocated, graph + s->graph_width, 0.0);
}
}
s->graph = graph;