Llewellyn/conky
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/conky.git synced 2024-12-26 04:17:33 +00:00
Code Issues Releases Activity

Reorganize, adjust wording.

Browse Source
This commit is contained in:
Brenden Matthews 2019-03-03 14:08:45 -05:00
parent 18d1a06dd3
commit 27f1e0fdac
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
CONTRIBUTING.md
View File

@ -2,12 +2,9 @@
Contributions are welcome from anyone. Contributions are welcome from anyone.
To report bugs or issues, open [new issues](https://github.com/brndnmtthws/conky/issues/new). ## Pull Request Guidelines
To submit code changes, open [new pull requests](https://github.com/brndnmtthws/conky/compare).
## Guidelines When submitting PRs, please:
Patches submitted in issues, email, or elsewhere may be ignored. When submitting PRs, please:
- Describe the changes, why they were necessary, etc - Describe the changes, why they were necessary, etc
- Describe how the changes affect existing behaviour - Describe how the changes affect existing behaviour
@ -15,20 +12,18 @@ Patches submitted in issues, email, or elsewhere may be ignored. When submitting
- Include unit tests when appropriate - Include unit tests when appropriate
- Include any relevant screenshots/evidence demonstrating that the changes work and have been tested - Include any relevant screenshots/evidence demonstrating that the changes work and have been tested
- Any new source files should include a GPLv3 license header - Any new source files should include a GPLv3 license header
- Any contributed code must be GPLv3 licensed - All new code must be GPLv3 licensed
- Always leave the code better than you found it - Try to leave the code better than you found it
- PRs with failed checks may be ignored or closed; please make sure - PRs with failed checks may be ignored or closed; please make sure
the build and checks pass if possible (and notify someone when the build the build and checks pass if possible (and notify someone when the build
system is not working) system is not working)
_Patches submitted in issues, email, or elsewhere may be ignored._
## Coding Style ## Coding Style
Code should be formatted using `clang-format`. By configuring Conky with `cmake -DCHECK_CODE_QUALITY=ON`, you will be able to run `make clang-format` to automatically format code. Code should be formatted using `clang-format`. By configuring Conky with `cmake -DCHECK_CODE_QUALITY=ON`, you will be able to run `make clang-format` to automatically format code. If code in your PR is not formatted according to [`.clang-format`](.clang-format), the checks will not pass.
If code in your PR is not formatted according to [`.clang-format`](.clang-format), the checks will not pass.
## Unit Testing ## Unit Testing
Unit tests are a relatively new addition to Conky, and most existing code does not have tests. Conky uses the [Catch2](https://github.com/catchorg/Catch2) unit testing framework. Conky uses the [Catch2](https://github.com/catchorg/Catch2) unit testing framework. If you are adding new functions or methods, please consider adding unit tests for that code. Additionally, if you'd like to add tests for existing code, that would be a welcome contribution.
If you are adding new functions or methods, please consider adding unit tests for that code. Additionally, if you'd like to add tests for existing code, that would be a welcome contribution.