Llewellyn/conky
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/conky.git synced 2025-02-05 13:38:33 +00:00
Code Issues Releases Activity

freebsd: infallibly allocate 16B buffer on stack

Browse Source 
there's no need to call calloc() for 16B, nor do we need to error-handle that allocation with exit()
This commit is contained in:
bi4k8 2023-05-05 00:42:58 +00:00 committed by bi4k8
parent 7fa3d113da
commit feb6a08537
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/freebsd.cc
View File

@ -551,10 +551,9 @@ char get_freq(char *p_client_buffer, size_t client_buffer_size,
return 0; return 0;
} }
freq_sysctl = (char *)calloc(16, sizeof(char)); char freq_sysctl[16] = {0};
if (freq_sysctl == nullptr) { exit(-1); }
snprintf(freq_sysctl, 16, "dev.cpu.%d.freq", (cpu - 1)); snprintf(freq_sysctl, sizeof(freq_sysctl), "dev.cpu.%d.freq", (cpu - 1));
if (GETSYSCTL(freq_sysctl, freq) == 0) { if (GETSYSCTL(freq_sysctl, freq) == 0) {
snprintf(p_client_buffer, client_buffer_size, p_format, snprintf(p_client_buffer, client_buffer_size, p_format,
@ -563,7 +562,6 @@ char get_freq(char *p_client_buffer, size_t client_buffer_size,
snprintf(p_client_buffer, client_buffer_size, p_format, 0.0f); snprintf(p_client_buffer, client_buffer_size, p_format, 0.0f);
} }
free(freq_sysctl);
return 1; return 1;
} }