Phil Sutter
fea72bd8f8
top.c: fix for unsigned underflow
...
Yes, I also thought these are monotonic counters. But it seems like they
are not, at least sometimes the value decreases by 1 leading to a very
very high cpu usage percentage being printed.
2009-09-15 23:16:39 +02:00
Phil Sutter
7fa59c6c90
better zero out allocated memory
2009-09-15 23:16:39 +02:00
Pavel Labath
09c0bccf55
Move vi modelines closer to the beginning, so they're more likely to be actually used.
2009-09-12 12:50:51 +02:00
Phil Sutter
e044093735
update machinery: complete transition
...
* Drop all need_mask alterations (no idea why there were here at all,
but surely not sane since they are missing in the non-linux
functions).
* Drop the update delay for update_meminfo(), as parsing /proc should
not lead to abnormal overhead.
* Check for x_initialised from inside update_x11info(), so we can call
it unconditionally.
2009-09-07 01:05:33 +02:00
Cesare Tirabassi
75ce3b259b
Fix if_running not working on linux when a top flavour is not running
2009-09-03 23:13:14 +02:00
Brenden Matthews
3f4127080e
Started on breaking up conky.c.
...
These changes will likely result in breakage, particularly with
different features enabled/disabled.
2009-08-05 16:46:51 -06:00
Brenden Matthews
2115d925e4
Code formatting.
2009-08-05 14:35:20 -06:00
Cesare Tirabassi
81c691d15a
add emacs indentation variables to source files in line with current vim settings
2009-07-28 23:44:22 +02:00
Brenden Matthews
d97cd93a1c
Add vim modelines.
2009-07-27 14:47:31 -06:00
Phil Sutter
c6a5a060cf
Use the internal process list for if_running on Linux
2009-06-20 01:46:59 +02:00
Pavel Labath
9e976d9dc4
Better parsing of process names containing funky chars
2009-06-14 00:02:50 +02:00
Pavel Labath
c0d1c313e9
Support for per-task I/O statistics - $top_io
...
Basically, I just added three new process properties (io_read, io_write, io_perc - representing
the amount of I/O done by the process during the update interval) and $top_io, that sorts
processes based on io_perc.
Atm, it's completely #ifdef'd, since it requires kernel support. But that creates some wierd
looking syntax at some places, so it may be better to remove some ifdefs. It even may be
possible to completely remove the ifdefs (ie. convert them to #ifdef linux) since the code will
compile just fine even if the kernel doesn't support I/O accounting. I'll leave that for someone
else to decide.
2009-06-12 19:39:45 +02:00
Brenden Matthews
f05829ad9a
Update copyright stuff, fix conky.conf weirdness.
2009-03-29 22:55:51 -06:00
Brenden Matthews
5b9d47c039
Couple fixes for the top_time stuff.
2009-02-08 10:13:54 -07:00
Alexander Graf
1ac4104e0b
top.c: Allow heavier optimization
...
This makes it possible for the compiler to do better optimizations by
adding "static" to functions which do not need to be exported.
Since some of them (e.g. the compare_*() functions) are called very
often, this may decrease conky's need of resources a bit.
2009-02-08 16:13:45 +01:00
Alexander Graf
04623066d7
Don't do unneeded sp_acopy() calls
2009-02-08 16:05:42 +01:00
Alexander Graf
9c679bf33f
Add ${top_time} sorting processes by CPU time
2009-02-07 15:01:50 +01:00
Brenden Matthews
dc3ed8df13
Removing old svn keywords.
2008-12-09 16:35:49 -07:00
Nikolas Garofil
c1c34ae443
'inline' removed from functions that are called from different files
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1187 7f574dfc-610e-0410-a909-a81674777703
2008-06-21 14:18:44 +00:00
Brenden Matthews
a6a4a4c548
* Replacing strdup() with strndup() throughout
...
(this is probably going to break a few things)
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1100 7f574dfc-610e-0410-a909-a81674777703
2008-04-02 18:44:49 +00:00
Brenden Matthews
be2cd44e6d
doc cleanup
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1090 7f574dfc-610e-0410-a909-a81674777703
2008-03-31 04:56:39 +00:00
Phil
ab63c2b024
rename all shadowing variables for -Wshadow
...
* sadly intuitive names like "time" or "index" are already
globally defined (functions in time.h and string.h)
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1070 7f574dfc-610e-0410-a909-a81674777703
2008-03-29 09:58:09 +00:00
Phil
2913a71216
the big relocation patch
...
* this moves all declarations to the beginning of their block
to prevent mixed declarations and code
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1068 7f574dfc-610e-0410-a909-a81674777703
2008-03-29 06:24:04 +00:00
Phil
d151828d23
make intense use of const keyword
...
* accidential writes to const char * are being detected
at compile time
* also clean up casting at some places
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1059 7f574dfc-610e-0410-a909-a81674777703
2008-03-29 03:45:36 +00:00
Phil
418b3d62e0
match signedness and format when scanning into variables
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1058 7f574dfc-610e-0410-a909-a81674777703
2008-03-29 03:01:48 +00:00
Phil
e306a2c2e8
some linting on function definitions
...
* instead of empty args "void" should always be specified.
Using this, the compiler can detect incorrect function calls,
like with update_stuff().
* No args seems to be interpreted as "unspecified args" by the
compiler, as with update_mail_count(). So no checking for
correctness of arguments when calling was done at all.
* This is not complete yet, as I still don't have any BSD for
testing.
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1055 7f574dfc-610e-0410-a909-a81674777703
2008-03-29 02:01:03 +00:00
Kevin Lyles
3d26a4880e
Reformatted all code
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1007 7f574dfc-610e-0410-a909-a81674777703
2008-02-20 20:30:45 +00:00
Kevin Lyles
c96f5b1143
Removed unused macros and removed X11 options from the options string unless X11 is enabled
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@1004 7f574dfc-610e-0410-a909-a81674777703
2008-02-20 10:01:13 +00:00
Brenden Matthews
35b4ed3aff
2008-01-05
...
* Applied some more submitted patches:
1) Add long forms of (most of) the command-line options.
2) Added an option (top_cpu_separate) that emulates top's "separate
cpus" option. Processor usage is shown as a percentage of a
single processor on your system, instead of a percentage
of all processors combined.
3) Adds a parameter (time) to top and top_mem that will show the
cumulative CPU time of a process.
4) Simplified integer rounding.
5) Fixed the window width when a goto is used.
6) Fixed the window width when an offset is used.
(thanks Kevin Lyles).
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@994 7f574dfc-610e-0410-a909-a81674777703
2008-01-06 01:35:14 +00:00
Brenden Matthews
27b4c8550c
clarifying licensing
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@904 7f574dfc-610e-0410-a909-a81674777703
2007-08-10 19:53:44 +00:00
Toni Spets
3872bafeef
Fixed memory leaks found with valgrind
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky1@875 7f574dfc-610e-0410-a909-a81674777703
2007-06-03 09:18:54 +00:00
David Carter
67ab68914a
new cpu % routines in top.c and linux.c
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@431 7f574dfc-610e-0410-a909-a81674777703
2005-11-27 06:56:35 +00:00
David Carter
b2ea953bee
no behavior change, just change the % calc math so the type conversion and operation precedence is explicit
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@407 7f574dfc-610e-0410-a909-a81674777703
2005-11-12 16:13:11 +00:00
David Carter
50866b5efe
fix stale static process pointer in top.c and add nodename to X window
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@402 7f574dfc-610e-0410-a909-a81674777703
2005-11-12 03:41:55 +00:00
David Carter
012457e9b2
fixed memory leak in new linked list top routine
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@401 7f574dfc-610e-0410-a909-a81674777703
2005-11-12 02:57:48 +00:00
Brenden Matthews
f827842abf
fixed small prob with memory stuff being wrong
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@391 7f574dfc-610e-0410-a909-a81674777703
2005-11-11 05:28:20 +00:00
Brenden Matthews
cfb93cb417
fixed some mem leaks
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@387 7f574dfc-610e-0410-a909-a81674777703
2005-11-10 04:19:43 +00:00
Brenden Matthews
6cd662ef13
fixed bug with process stuff being wrong on 64 bit machines
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@385 7f574dfc-610e-0410-a909-a81674777703
2005-11-10 01:48:36 +00:00
David Carter
9b2401b36e
new top routines using linked lists instead of arrays
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@384 7f574dfc-610e-0410-a909-a81674777703
2005-11-10 01:20:19 +00:00
Brenden Matthews
60499dcc74
some fixes that didnt fix anything
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@381 7f574dfc-610e-0410-a909-a81674777703
2005-11-09 02:15:13 +00:00
Philip Kovacs
d841dce48a
use unsigned long not int for cpu% calcs. fixes bug# 1351686. patch bu boojit
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@375 7f574dfc-610e-0410-a909-a81674777703
2005-11-08 23:03:25 +00:00
Brenden Matthews
a3212822df
fixing small mistake; adding Nattfodd <Nattfodd@gmail.com> to AUTHORS
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@339 7f574dfc-610e-0410-a909-a81674777703
2005-09-29 03:40:12 +00:00
Brenden Matthews
b8e385f663
Fixed top_mem as per Nattfodd's email on conky-development list
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@338 7f574dfc-610e-0410-a909-a81674777703
2005-09-29 03:34:05 +00:00
Brenden Matthews
471fcabc90
fixed graph width issue
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@262 7f574dfc-610e-0410-a909-a81674777703
2005-09-04 03:43:18 +00:00
Brenden Matthews
0732d1c4f3
implemented qsort() in top.c instead of using my lame algorithm
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@176 7f574dfc-610e-0410-a909-a81674777703
2005-08-25 01:13:01 +00:00
Brenden Matthews
e5893c4329
moved stuff
...
git-svn-id: https://conky.svn.sourceforge.net/svnroot/conky/trunk/conky@130 7f574dfc-610e-0410-a909-a81674777703
2005-08-21 22:10:54 +00:00