Mithil Poojary
0a4eb8fda5
Replace vulnerable functions with safer alternatives
2021-01-23 18:39:01 -06:00
Kushagra Sinha
4cb79fb3e1
Revert "exec.cc: Cache the result to another variable and return it when we have a empty/invalid value. ( #646 )"
...
This reverts commit a644600bc5
.
2019-03-03 13:24:23 -05:00
Brenden Matthews
46abd3b75a
Apply fixes from clang-tidy/format.
2019-02-23 17:13:19 -05:00
Brenden Matthews
90673cf161
Make GitLab build work with clang checks.
2019-02-23 17:13:19 -05:00
lasers
7eec746b82
update copyright year to 2019
2019-01-05 11:15:36 -06:00
Brenden Matthews
bc0ec94c10
Fix execi scanning segfault due to bad free. ( #693 )
...
This should resolve #690 .
2018-12-05 16:21:04 -05:00
su8
a644600bc5
exec.cc: Cache the result to another variable and return it when we have a empty/invalid value. ( #646 )
2018-09-01 16:15:33 +02:00
lasers
bbaa0e9ac8
exec.cc: Free malloced pointer after use in scan_exec_arg() ( #607 )
2018-08-13 14:55:31 -04:00
su8
3d5e152a8b
exec.cc: Calculate the command length once and compare it, check only the first char once
2018-08-09 11:17:23 -04:00
su8
e242fea685
exec.cc: Move the escaping code into standalone function
2018-08-09 11:17:23 -04:00
su8
08f7cd6732
exec.cc: Make sure to test the first char only
2018-08-09 11:17:23 -04:00
su8
260554883a
exec.cc: Add some overflow checks
2018-08-09 11:17:23 -04:00
su8
e229f1a398
exec.cc: permit wrapping commands in quotes
2018-08-09 11:17:23 -04:00
Nikolas Garofil
5dd23796a6
Use unsigned int for p_max_size in obj_cb.print
2018-08-08 15:54:47 -04:00
Brenden Matthews
623fb83379
Fix for $exec regression introduced by 4b92556f
. ( #514 )
...
This resolves #510 .
2018-05-24 20:24:09 -04:00
Brenden Matthews
4b92556fca
Build improvements: clang-tidy, sonar, Dockerfile. ( #488 )
2018-05-12 19:26:31 -04:00
Brenden Matthews
eebc8c653b
Add formatting/static analysis ( #486 )
...
* Reform source with clang-format.
Rules applied with:
$ find . -iname *.h -o -iname *.cc | xargs clang-format \
-style=file -i -fallback-style=google
* Add clang-format and analyze to build.
Based on the excellent work at: https://github.com/ttroy50/cmake-examples
* Clean up CMake stuff on macOS.
* Remove vim/emacs modelines.
* Update copyright dates.
* Build fixes.
* Build fixes.
* Build fixes.
* Build fixes.
* Build fixes.
* Build fixes.
2018-05-12 12:03:00 -04:00
Marc Payne
adae1f6293
Refactor the exec callback system
...
The main purpose of this commit is to ensure that exec callbacks are
registered at startup (or config reload), so that they have a chance to
run on the first update interval. Much of the code in exec.cc got
consolidated, making it easier to follow. Several checks for NULL
pointers should eliminate some obscure segfaults I noticed, as well.
During the refactoring, I implemented height and width arguments for
execbar and execgauge. The functionality was already there, but wasn't
being used. All this is accompanied by updates to the man page and
plenty of code comments.
2016-01-09 10:19:48 -07:00
Pavel Labath
b34a1a21e7
Use lround instead of std::lround
...
for unknown reasons DragonFly's gcc does not have lround in the std namespace
cf. sf.net #3289079
2012-07-13 20:17:54 +02:00
Brenden Matthews
ddef05d4eb
Update version, copyright.
2012-05-03 16:34:44 -07:00
Pavel Labath
b96f112106
Make $exec et al. use the new callback system
...
I removed the code for automatic killing of stuck children, because (by admission of the person
who wrote it) it wasn't working. I also removed the $pre_exec variable, because one can use lua
to generate the config on the startup, if one wants to.
2011-02-27 22:43:32 +01:00
Pavel Labath
f1bc24f199
fclose(3) instead of pclose(3) as the latter seems to leak file descriptors
...
Signed-off-by: Nikos Ntarmos <ntarmos@cs.uoi.gr>
Signed-off-by: Pavel Labath <pavelo@centrum.sk>
Conflicts:
src/exec.c - had to merge manually
2010-12-05 21:16:01 +01:00
Nikolas Garofil
fcf318c6dd
Fix bug with SF ID 3101185 (manual merge)
2010-11-20 17:18:34 +01:00
Nikolas Garofil
0ee557a4ee
Fix bug with SF ID 3101185
2010-11-20 16:59:32 +01:00
Nikolas Garofil
e73da6b72e
Fix compiling without X11 support
2010-11-13 23:59:31 +01:00
Pavel Labath
47d9a63dff
Make update_interval{,_on_battery} lua settings
2010-09-11 14:25:19 +02:00
Pavel Labath
ef2b39a97f
Make text_buffer_size a lua setting
2010-08-29 23:50:32 +02:00
Pavel Labath
0f213c89f2
Simplify timed_thread time calculations with some c++0x magic
2010-06-10 19:19:49 +02:00
Nikolas Garofil
e7ed9a5060
Revert "Use "using namespace std;" and remove all std::'s"
...
This reverts commit 41e80b9833
.
2010-02-24 20:10:26 +01:00
Nikolas Garofil
41e80b9833
Use "using namespace std;" and remove all std::'s
...
I'm doing this because otherwise i'll will forget to add all those
std::'s and will lose a LOT of time finding the problems.
If you don't agree, undo this patch...
...but i hope you won't :)
2010-02-24 19:39:45 +01:00
Nikolas Garofil
72d581279a
Use free_and_zero in [d-k]*.cc where appropriate
2010-02-23 23:13:11 +01:00
Nikolas Garofil
b206ecc93d
new should be combined with delete instead of free (to stop valgrind from complaining)
2010-02-11 14:44:15 +01:00
Nikolas Garofil
463836ebf9
Combine print_execp and print_exec as much as possible
2010-02-11 01:08:25 +01:00
Nikolas Garofil
f0ed783041
dog^H^H^Hcat should become cat in all exec-related vars
2010-02-10 23:31:35 +01:00
Nikolas Garofil
aea8d3ed52
Combine print_texeci and print_execi as much as possible
2010-02-10 21:23:21 +01:00
Nikolas Garofil
c010d7cd00
Let execp use fill_p
2010-02-10 19:45:42 +01:00
Nikolas Garofil
36ad680a98
Let print_execi and print_texeci call fill_p for filling p
2010-02-10 19:04:31 +01:00
Nikolas Garofil
9fefa79551
Obsolete threaded_exec_caller with help of previous commit
2010-02-10 15:54:50 +01:00
Nikolas Garofil
e017870b58
Combine print_texeci and print_texecpi as much as possible
2010-02-10 15:21:00 +01:00
Nikolas Garofil
456142241c
Combine print_execi and print_execpi as much as possible
2010-02-10 15:02:00 +01:00
Nikolas Garofil
a5ed45fc7b
put same stuff from print_texeci and print_texecpi in a separate function
2010-02-08 16:12:46 +01:00
Nikolas Garofil
223eefcdd7
Forgot one letter in previous commit...
2010-02-07 14:46:22 +01:00
Nikolas Garofil
01e3bb62a2
Implements texecpi variable
2010-02-07 10:29:43 +01:00
Brenden Matthews
002685c0ce
Make timed-thread a lib, rename files.
2010-01-13 10:52:54 -08:00
Pavel Labath
c62266a5db
Make sure the $exec buffer is null-terminated
2010-01-13 13:34:14 +01:00
Brenden Matthews
7e78f036f0
Use consistent naming for build option macros.
...
Probably have broken some build features with this commit.
2010-01-06 18:39:44 -08:00
Brenden Matthews
7ff762e4af
Resolve issues with timed_thread rewrite WIP.
2010-01-04 19:21:12 -08:00
Brenden Matthews
01ac47d082
Implement timed_thread rewrite in C++.
...
Rewrote timed_thread library in C++ using fancy new C++0x features. The
main reason for this is to phase out poor encapsulation and C-style
function pointers.
2010-01-04 19:21:12 -08:00