exa/xtests/links_T

[36m/testcases/[1;34mlinks[0m
[38;5;244m├──[0m [36mbroken[0m [31m->[0m [4;31mnowhere[0m
[38;5;244m│  └──[0m [31m<No such file or directory (os error 2)>[0m
[38;5;244m├──[0m [36mcurrent_dir[0m [38;5;244m->[0m [1;34m.[0m
[38;5;244m├──[0m [36mforbidden[0m [31m->[0m [4;31m/proc/1/root[0m
[38;5;244m│  └──[0m [31m<Permission denied (os error 13)>[0m
[38;5;244m├──[0m [36mitself[0m [31m->[0m [4;31mitself[0m
[38;5;244m│  └──[0m [31m<Too many levels of symbolic links (os error 40)>[0m
[38;5;244m├──[0m [36mparent_dir[0m [38;5;244m->[0m [1;34m..[0m
[38;5;244m├──[0m [36mroot[0m [38;5;244m->[0m [1;34m/[0m
[38;5;244m├──[0m some_file
[38;5;244m├──[0m [36msome_file_absolute[0m [38;5;244m->[0m [36m/testcases/links/[0msome_file
[38;5;244m├──[0m [36msome_file_relative[0m [38;5;244m->[0m some_file
[38;5;244m└──[0m [36musr[0m [38;5;244m->[0m [36m/[1;34musr[0m
-												Protect xtests against different default users

The Vagrant tests assumed that there’d be a user called “vagrant” that would run the tests and create the files by default. Files would be owned by vagrant:vagrant by default, and this worked, until it came time to change that username. The naïve method was a search-and-replace, but this caused problems when the new user’s name wasn’t exactly the same length as the previous one.

So to fix this, we now have our own user, named after the first animal I thought of, that makes the files’ owners and groups independent of the default user of whichever VM image the xtests are running on.

Another place where it was hard-coded was the home directory, which was “/home/vagrant”, where the awkward testcases live. That last one has been changed to just “/testcases”, which has no mention of the user in it.

											
										
										
											2017-04-28 18:34:23 +00:00
+								[36m/testcases/[1;34mlinks[0m
-												Don't prepend current path to symlink targets

It's confusing, and `ls` doesn't do this either. We're not prepending
the current path to all of the directory entries, and the user is going
to interpret the symlink target as relative to the directory containing
the symlink.

											
										
										
											2017-04-25 23:06:26 +00:00
+								[38;5;244m├──[0m [36mbroken[0m [31m->[0m [4;31mnowhere[0m
-												Add some symlink testcases

											
										
										
											2016-10-29 18:58:34 +00:00
+								[38;5;244m│  └──[0m [31m<No such file or directory (os error 2)>[0m
-												Add tests for relative symlinks

											
										
										
											2017-04-30 10:58:29 +00:00
+								[38;5;244m├──[0m [36mcurrent_dir[0m [38;5;244m->[0m [1;34m.[0m
-												Add some symlink testcases

											
										
										
											2016-10-29 18:58:34 +00:00
+								[38;5;244m├──[0m [36mforbidden[0m [31m->[0m [4;31m/proc/1/root[0m
 								[38;5;244m│  └──[0m [31m<Permission denied (os error 13)>[0m
-												Add tests for relative symlinks

											
										
										
											2017-04-30 10:58:29 +00:00
+								[38;5;244m├──[0m [36mitself[0m [31m->[0m [4;31mitself[0m
 								[38;5;244m│  └──[0m [31m<Too many levels of symbolic links (os error 40)>[0m
 								[38;5;244m├──[0m [36mparent_dir[0m [38;5;244m->[0m [1;34m..[0m
-												Special-case the root directory when linking to it

It’s the only file where its path is the same as its file name, and has been the source of numerous bugs in the past… this special-case isn’t very clean, but it works.

											
										
										
											2017-04-29 10:52:10 +00:00
+								[38;5;244m├──[0m [36mroot[0m [38;5;244m->[0m [1;34m/[0m
-												Add tests for relative symlinks

											
										
										
											2017-04-30 10:58:29 +00:00
+								[38;5;244m├──[0m some_file
 								[38;5;244m├──[0m [36msome_file_absolute[0m [38;5;244m->[0m [36m/testcases/links/[0msome_file
 								[38;5;244m├──[0m [36msome_file_relative[0m [38;5;244m->[0m some_file
-												Add some symlink testcases

											
										
										
											2016-10-29 18:58:34 +00:00
+								[38;5;244m└──[0m [36musr[0m [38;5;244m->[0m [36m/[1;34musr[0m