From 476299e21f92128d048f99d55958490251f20978 Mon Sep 17 00:00:00 2001 From: Benjamin Sago Date: Thu, 28 Sep 2017 18:59:51 +0100 Subject: [PATCH] A note to my future self MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It’s important to capture the current behaviour, even if it ends up being totally wrong. --- src/fs/feature/ignore.rs | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/fs/feature/ignore.rs b/src/fs/feature/ignore.rs index 042f492..f798137 100644 --- a/src/fs/feature/ignore.rs +++ b/src/fs/feature/ignore.rs @@ -74,6 +74,8 @@ where I: Iterator let iter = iter.filter(|el| !el.is_empty()); let iter = iter.filter(|el| !el.starts_with("#")); + // TODO: Figure out if this should trim whitespace or not + // Errors are currently being ignored... not a good look IgnorePatterns::parse_from_iter(iter).0 } @@ -114,6 +116,13 @@ mod test { assert_eq!(patterns, file_lines_to_patterns(stuff.into_iter())); } + #[test] + fn parse_some_whitespacey_lines() { + let stuff = vec![ " *.mp3", " ", " a ", "README.md " ]; + let reals = vec![ " *.mp3", " ", " a ", "README.md " ]; + let (patterns, _) = IgnorePatterns::parse_from_iter(reals.into_iter()); + assert_eq!(patterns, file_lines_to_patterns(stuff.into_iter())); + }