Llewellyn/exa
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/exa.git synced 2024-11-23 04:22:06 +00:00
Code Issues Projects Releases Wiki Activity

Reword this comment

Browse Source
This commit is contained in:
Benjamin Sago 2017-09-13 20:45:41 +01:00
parent aa2e3a5d9e
commit 68e70bf036
1 changed files with 17 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/output/details.rs
View File

@ -203,23 +203,24 @@ impl<'a> Render<'a> {
// There are three “levels” of extended attribute support:
//
// 1. If we’re compiling without that feature, then
// exa pretends no files have attributes.
// 2. If the feature is enabled but the --extended flag
// hasn’t been specified, then display an @ in the
// permissions column for files with xattrs, but don’t
// display anything else.
// 3. If the --extended flag *has* been specified, then
// display the @, the attributes and their lengths,
// and any errors encountered when getting them.
// exa pretends all files have no attributes.
// 2. If the feature is enabled and the --extended flag
// has been specified, then display an @ in the
// permissions column for files with attributes, the
// names of all attributes and their lengths, and any
// errors encountered when getting them.
// 3. If the --extended flag *hasn’t* been specified, then
// display the @, but don’t display anything else.
//
// For a while, exa took a stricter approach to (2): if
// an error occurred while checking a file’s xattrs, exa
// would display that error even though the attributes
// weren’t actually being shown! This was confusing, as
// users were being shown errors for something they didn’t
// explicitly ask for, and just cluttered up the output.
// So now errors aren’t printed unless the user passes
// --extended to signify that they want to see them.
// For a while, exa took a stricter approach to (3):
// if an error occurred while checking a file’s xattrs to
// see if it should display the @, exa would display that
// error even though the attributes weren’t actually being
// shown! This was confusing, as users were being shown
// errors for something they didn’t explicitly ask for,
// and just cluttered up the output. So now errors aren’t
// printed unless the user passes --extended to signify
// that they want to see them.
if xattr::ENABLED {
match file.path.attributes() {