Llewellyn/exa
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/exa.git synced 2025-02-10 14:28:44 +00:00
Code Issues Projects Releases Wiki Activity

Prefer background colour when painting icons

Browse Source 
The rationale here is that there's more of a background colour than the foreground colour when painting text, and having a gap of no background colour in between the icon and the file name looks weird.

Fixes GH-561.
This commit is contained in:
Benjamin Sago 2020-10-24 18:29:28 +01:00
parent 67a6cdd46a
commit 976db01b3e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/output/icons.rs
View File

@ -27,8 +27,16 @@ impl Icons {
} }
/// Converts the style used to paint a file name into the style that should be
/// used to paint an icon.
///
/// - The background colour should be preferred to the foreground colour, as
/// if one is set, it’s the more “obvious” colour choice.
/// - If neither is set, just use the default style.
/// - Attributes such as bold or underline should not be used to paint the
/// icon, as they can make it look weird.
pub fn iconify_style<'a>(style: Style) -> Style { pub fn iconify_style<'a>(style: Style) -> Style {
style.foreground style.background.or(style.foreground)
.map(Style::from) .map(Style::from)
.unwrap_or_default() .unwrap_or_default()
} }