From 1c31e07d34ab53e83106bd40c28a8d5bc5ea2f46 Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Wed, 19 Aug 2015 19:42:06 +0900 Subject: [PATCH] [install] Improve error message --- install | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/install b/install index dae6a74..1e59e63 100755 --- a/install +++ b/install @@ -21,16 +21,21 @@ ask() { check_binary() { echo -n " - Checking fzf executable ... " - local output=$("$fzf_base"/bin/fzf --version 2>&1) - if [ "$version" = "$output" ]; then + local output + output=$("$fzf_base"/bin/fzf --version 2>&1) + if [ $? -ne 0 ]; then + echo "Error: $output" + binary_error="Invalid binary" + elif [ "$version" != "$output" ]; then + echo "$output != $version" + binary_error="Invalid version" + else echo "$output" binary_error="" - else - echo "$output != $version" - rm -f "$fzf_base"/bin/fzf - binary_error="Invalid binary" - return 1 + return 0 fi + rm -f "$fzf_base"/bin/fzf + return 1 } symlink() {