Remove $FZF_PREVIEW_PIXEL_{WIDTH,HEIGHT} (#2544)

They are not neccessary because we can use a program such as chafa that
can resize images by the terminal columns and lines.
This commit is contained in:
Junegunn Choi 2023-10-26 21:36:57 +09:00
parent d02b9442a5
commit 3277e8c89c
No known key found for this signature in database
GPG Key ID: 254BC280FEF9C627
3 changed files with 6 additions and 8 deletions

View File

@ -4,8 +4,6 @@ CHANGELOG
0.43.1 0.43.1
------ ------
- (Experimental) Sixel image support in preview window (not available on Windows) - (Experimental) Sixel image support in preview window (not available on Windows)
- `$FZF_PREVIEW_PIXEL_WIDTH` and `$FZF_PREVIEW_PIXEL_HEIGHT` are set to
the pixel width and height of the preview window
- [bin/fzf-preview.sh](bin/fzf-preview.sh) is added to demonstrate how to - [bin/fzf-preview.sh](bin/fzf-preview.sh) is added to demonstrate how to
display an image using Kitty image protocol or Sixel. You can use it display an image using Kitty image protocol or Sixel. You can use it
like so: like so:

View File

@ -2,6 +2,10 @@
# #
# The purpose of this script is to demonstrate how to preview a file or an # The purpose of this script is to demonstrate how to preview a file or an
# image in the preview window of fzf. # image in the preview window of fzf.
#
# Dependencies:
# - https://github.com/hpjansson/chafa
# - https://github.com/sharkdp/bat
file=$1 file=$1
type=$(file --mime-type "$file") type=$(file --mime-type "$file")
@ -23,8 +27,8 @@ elif [[ $KITTY_WINDOW_ID ]]; then
# you have to use 'stream' # you have to use 'stream'
kitty icat --clear --transfer-mode=memory --stdin=no --place="${FZF_PREVIEW_COLUMNS}x${FZF_PREVIEW_LINES}@0x0" "$file" | sed \$d kitty icat --clear --transfer-mode=memory --stdin=no --place="${FZF_PREVIEW_COLUMNS}x${FZF_PREVIEW_LINES}@0x0" "$file" | sed \$d
echo -en "\e[m" echo -en "\e[m"
elif [[ -n $FZF_PREVIEW_PIXEL_WIDTH ]]; then elif command -v chafa > /dev/null; then
convert "$file" -resize "${FZF_PREVIEW_PIXEL_WIDTH}x${FZF_PREVIEW_PIXEL_HEIGHT}>" -dither FloydSteinberg sixel:- chafa -f sixel -s "${FZF_PREVIEW_COLUMNS}x${FZF_PREVIEW_LINES}" "$file"
else else
file "$file" file "$file"
fi fi

View File

@ -2775,10 +2775,6 @@ func (t *Terminal) Loop() {
env = append(env, "FZF_PREVIEW_"+lines) env = append(env, "FZF_PREVIEW_"+lines)
env = append(env, columns) env = append(env, columns)
env = append(env, "FZF_PREVIEW_"+columns) env = append(env, "FZF_PREVIEW_"+columns)
if pwindowSize.PxWidth > 0 {
env = append(env, fmt.Sprintf("FZF_PREVIEW_PIXEL_WIDTH=%d", pwindowSize.PxWidth))
env = append(env, fmt.Sprintf("FZF_PREVIEW_PIXEL_HEIGHT=%d", pwindowSize.PxHeight))
}
} }
cmd.Env = env cmd.Env = env