From 6816b7d95b54330224020b4304db7fd5a5ea1ba1 Mon Sep 17 00:00:00 2001 From: jaydee-coder <187227976+jaydee-coder@users.noreply.github.com> Date: Mon, 4 Nov 2024 05:26:19 -0800 Subject: [PATCH] docker: fix dockerfile warnings (#4080) The following warnings were emitted when running `make docker-test`: ``` 2 warnings found (use docker --debug to expand): - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 11) - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 12) ``` This change fixes both of these 2 trivial warnings. --- Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index e31f804..93e229f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -8,5 +8,5 @@ RUN echo '. ~/.bashrc' >> ~/.bash_profile RUN rm -f /etc/bash.bashrc COPY . /fzf RUN cd /fzf && make install && ./install --all -ENV LANG C.UTF-8 -CMD tmux new 'set -o pipefail; ruby /fzf/test/test_go.rb | tee out && touch ok' && cat out && [ -e ok ] +ENV LANG=C.UTF-8 +CMD ["bash", "-ic", "tmux new 'set -o pipefail; ruby /fzf/test/test_go.rb | tee out && touch ok' && cat out && [ -e ok ]"]