From e7097a9d25e0a64cdc9d199f243526b85c42d888 Mon Sep 17 00:00:00 2001 From: ssjhv <17730307+ssjhv@users.noreply.github.com> Date: Fri, 12 Jul 2019 22:47:51 -0700 Subject: [PATCH] [fish] Remove perl from fish key bindings (#1635) Perl was used to remove the trailing newline character, but fzf already has --print0 to use null character as terminators, and fish read -z is expecting null character as terminators. There is no reason to depend on perl if --print0 is passed to fzf invocation. --- shell/key-bindings.fish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/key-bindings.fish b/shell/key-bindings.fish index 57704f7..035ba55 100644 --- a/shell/key-bindings.fish +++ b/shell/key-bindings.fish @@ -47,7 +47,7 @@ function fzf_key_bindings # history's -z flag was added in fish 2.4.0, so don't use it for versions # before 2.4.0. if [ "$FISH_MAJOR" -gt 2 -o \( "$FISH_MAJOR" -eq 2 -a "$FISH_MINOR" -ge 4 \) ]; - history -z | eval (__fzfcmd) --read0 -q '(commandline)' | perl -pe 'chomp if eof' | read -lz result + history -z | eval (__fzfcmd) --read0 --print0 -q '(commandline)' | read -lz result and commandline -- $result else history | eval (__fzfcmd) -q '(commandline)' | read -l result