From f84b3de24b63e2e26cbfa2a24e61a4173824fffd Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Thu, 25 Mar 2021 19:56:18 +0900 Subject: [PATCH] Automatically set /dev/tty as STDIN on execute action https://github.com/junegunn/fzf/issues/1360#issuecomment-788178140 # Redirect /dev/tty to suppress "Vim: Warning: Input is not from a terminal" ls | fzf --bind "enter:execute(vim {} < /dev/tty)" # With this change, we can omit "< /dev/tty" part ls | fzf --bind "enter:execute(vim {})" --- src/terminal.go | 2 +- src/tui/ttyname_unix.go | 16 ++++++++++++++++ src/tui/ttyname_windows.go | 7 +++++++ 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/src/terminal.go b/src/terminal.go index 53a3276..263e2c5 100644 --- a/src/terminal.go +++ b/src/terminal.go @@ -1723,7 +1723,7 @@ func (t *Terminal) executeCommand(template string, forcePlus bool, background bo command := t.replacePlaceholder(template, forcePlus, string(t.input), list) cmd := util.ExecCommand(command, false) if !background { - cmd.Stdin = os.Stdin + cmd.Stdin = tui.TtyIn() cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr t.tui.Pause(true) diff --git a/src/tui/ttyname_unix.go b/src/tui/ttyname_unix.go index 69bdfa5..68298cd 100644 --- a/src/tui/ttyname_unix.go +++ b/src/tui/ttyname_unix.go @@ -4,6 +4,7 @@ package tui import ( "io/ioutil" + "os" "syscall" ) @@ -29,3 +30,18 @@ func ttyname() string { } return "" } + +// TtyIn returns terminal device to be used as STDIN, falls back to os.Stdin +func TtyIn() *os.File { + in, err := os.OpenFile(consoleDevice, syscall.O_RDONLY, 0) + if err != nil { + tty := ttyname() + if len(tty) > 0 { + if in, err := os.OpenFile(tty, syscall.O_RDONLY, 0); err == nil { + return in + } + } + return os.Stdin + } + return in +} diff --git a/src/tui/ttyname_windows.go b/src/tui/ttyname_windows.go index 5354b74..8db490a 100644 --- a/src/tui/ttyname_windows.go +++ b/src/tui/ttyname_windows.go @@ -2,6 +2,13 @@ package tui +import "os" + func ttyname() string { return "" } + +// TtyIn on Windows returns os.Stdin +func TtyIn() *os.File { + return os.Stdin +}