mirror of
https://github.com/Llewellynvdm/fzf.git
synced 2024-06-03 07:50:49 +00:00
2fe1e28220
I profiled fzf and it turned out that it was spending significant amount of time repeatedly converting character arrays into Unicode codepoints. This commit greatly improves search performance after the initial scan by memoizing the converted results. This commit also addresses the problem of unbounded memory usage of fzf. fzf is a short-lived process that usually processes small input, so it was implemented to cache the intermediate results very aggressively with no notion of cache expiration/eviction. I still think a proper implementation of caching scheme is definitely an overkill. Instead this commit introduces limits to the maximum size (or minimum selectivity) of the intermediate results that can be cached.
53 lines
1.8 KiB
Go
53 lines
1.8 KiB
Go
package algo
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func assertMatch(t *testing.T, fun func(bool, *[]rune, []rune) (int, int), caseSensitive bool, input string, pattern string, sidx int, eidx int) {
|
|
if !caseSensitive {
|
|
pattern = strings.ToLower(pattern)
|
|
}
|
|
runes := []rune(input)
|
|
s, e := fun(caseSensitive, &runes, []rune(pattern))
|
|
if s != sidx {
|
|
t.Errorf("Invalid start index: %d (expected: %d, %s / %s)", s, sidx, input, pattern)
|
|
}
|
|
if e != eidx {
|
|
t.Errorf("Invalid end index: %d (expected: %d, %s / %s)", e, eidx, input, pattern)
|
|
}
|
|
}
|
|
|
|
func TestFuzzyMatch(t *testing.T) {
|
|
assertMatch(t, FuzzyMatch, false, "fooBarbaz", "oBZ", 2, 9)
|
|
assertMatch(t, FuzzyMatch, true, "fooBarbaz", "oBZ", -1, -1)
|
|
assertMatch(t, FuzzyMatch, true, "fooBarbaz", "oBz", 2, 9)
|
|
assertMatch(t, FuzzyMatch, true, "fooBarbaz", "fooBarbazz", -1, -1)
|
|
}
|
|
|
|
func TestExactMatchNaive(t *testing.T) {
|
|
assertMatch(t, ExactMatchNaive, false, "fooBarbaz", "oBA", 2, 5)
|
|
assertMatch(t, ExactMatchNaive, true, "fooBarbaz", "oBA", -1, -1)
|
|
assertMatch(t, ExactMatchNaive, true, "fooBarbaz", "fooBarbazz", -1, -1)
|
|
}
|
|
|
|
func TestPrefixMatch(t *testing.T) {
|
|
assertMatch(t, PrefixMatch, false, "fooBarbaz", "Foo", 0, 3)
|
|
assertMatch(t, PrefixMatch, true, "fooBarbaz", "Foo", -1, -1)
|
|
assertMatch(t, PrefixMatch, false, "fooBarbaz", "baz", -1, -1)
|
|
}
|
|
|
|
func TestSuffixMatch(t *testing.T) {
|
|
assertMatch(t, SuffixMatch, false, "fooBarbaz", "Foo", -1, -1)
|
|
assertMatch(t, SuffixMatch, false, "fooBarbaz", "baz", 6, 9)
|
|
assertMatch(t, SuffixMatch, true, "fooBarbaz", "Baz", -1, -1)
|
|
}
|
|
|
|
func TestEmptyPattern(t *testing.T) {
|
|
assertMatch(t, FuzzyMatch, true, "foobar", "", 0, 0)
|
|
assertMatch(t, ExactMatchNaive, true, "foobar", "", 0, 0)
|
|
assertMatch(t, PrefixMatch, true, "foobar", "", 0, 0)
|
|
assertMatch(t, SuffixMatch, true, "foobar", "", 6, 6)
|
|
}
|