From 4788092423fd42387b49f60d2a2d89db0deb6bab Mon Sep 17 00:00:00 2001 From: Thomas O'Donnell Date: Sun, 14 Jun 2020 22:02:24 +0200 Subject: [PATCH] docs: remove redundant settings in Contributing guide (#1326) Have removed some redundant settings in the CONTRIBUTING.md since starship should be the only application using the `STARSHIP_LOG` env var. --- CONTRIBUTING.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c5b680ed..dd470e8f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,10 +32,10 @@ For example, to enable the trace logs, run the following: ```sh # Run installed starship -STARSHIP_LOG=starship=trace starship +STARSHIP_LOG=trace starship # Run with cargo -STARSHIP_LOG=starship=trace cargo run +STARSHIP_LOG=trace cargo run ``` ## Linting @@ -84,7 +84,7 @@ For tests that depend on having preexisting state, whatever needed state will ha Any tests that depend on File I/O should use [`sync_all()`](https://doc.rust-lang.org/std/fs/struct.File.html#method.sync_all) when creating files or after writing to files. -Any tests that use `tempfile::tempdir` should take care to call `dir.close()` after usage to ensure the lifecycle of the directory can be reasoned about. +Any tests that use `tempfile::tempdir` should take care to call `dir.close()` after usage to ensure the lifecycle of the directory can be reasoned about. Any tests that use `create_fixture_repo()` should remove the returned directory after usage with `remove_dir_all::remove_dir_all()`.