Llewellyn/starship
1
0
Fork 0
mirror of https://github.com/Llewellynvdm/starship.git synced 2024-11-19 11:35:16 +00:00
Code Issues Releases Activity

fix: Fix the python module ignoring error codes (#563)

Browse Source 
This is a quick fix to stop the python module from displaying error
messages that have been printed to stderr as the version.
This commit is contained in:
Thomas O'Donnell 2019-10-20 10:42:27 +02:00 committed by Matan Kushner
parent 7e21f5c6b6
commit 7b9197a67e
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/modules/python.rs
View File

@ -68,6 +68,13 @@ fn get_pyenv_version() -> Option<String> {
fn get_python_version() -> Option<String> { fn get_python_version() -> Option<String> {
match Command::new("python").arg("--version").output() { match Command::new("python").arg("--version").output() {
Ok(output) => { Ok(output) => {
if !output.status.success() {
log::warn!(
"Non-Zero exit code '{}' when executing `python --version`",
output.status
);
return None;
}
// We have to check both stdout and stderr since for Python versions // We have to check both stdout and stderr since for Python versions
// < 3.4, Python reports to stderr and for Python version >= 3.5, // < 3.4, Python reports to stderr and for Python version >= 3.5,
// Python reports to stdout // Python reports to stdout