2020-01-14 03:04:17 +00:00
|
|
|
<!--
|
|
|
|
|
|
|
|
|
|
Some key notes before you open a PR:
|
|
|
|
|
|
|
|
|
|
1. Select which branch should this PR be merged in?
|
|
|
|
|
2. PR name follows [convention](http://karma-runner.github.io/4.0/dev/git-commit-msg.html)
|
|
|
|
|
3. Update necessary Documentation
|
|
|
|
|
4. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also, if you're new here
|
|
|
|
|
|
|
|
|
|
- Documentation Guidelines => https://github.com/frappe/erpnext/wiki/Updating-Documentation
|
|
|
|
|
|
|
|
|
|
- Contribution Guide => https://github.com/frappe/bench/blob/master/docs/contribution_guidelines.md
|
|
|
|
|
|
|
|
|
|
- Pull Request Checklist => https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist
|
|
|
|
|
|
|
|
|
|
-->
|
|
|
|
|
|
|
|
|
|
What type of a PR is this?
|
|
|
|
|
|
|
|
|
|
- [ ] Changes to Existing Features
|
|
|
|
|
- [ ] New Feature Submissions
|
|
|
|
|
- [ ] Bug Fix
|
|
|
|
|
- [ ] Breaking Change (include change in API behaviours, etc.)
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
> Please provide enough information so that others can review your pull request:
|
|
|
|
|
|
|
|
|
|
<!-- You can skip this if you're fixing a typo or updating existing documentation -->
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
|
|
|
|
> Explain the **details** for making this change. What existing problem does the pull request solve? The following checklist could help
|
2018-05-30 16:38:27 +00:00
|
|
|
|
|
|
|
|
- [ ] Have you followed the guidelines in our Contributing document?
|
|
|
|
|
- [ ] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?
|
|
|
|
|
- [ ] Have you lint your code locally prior to submission?
|
|
|
|
|
- [ ] Have you successfully run tests with your changes locally?
|
|
|
|
|
- [ ] Does your commit message have an explanation for your changes and why you'd like us to include them?
|
|
|
|
|
- [ ] Docs have been added / updated
|
|
|
|
|
- [ ] Tests for the changes have been added (for bug fixes / features)
|
|
|
|
|
- [ ] Did you modify the existing test cases? If yes, why?
|
|
|
|
|
|
|
|
|
|
---
|
|
|
|
|
|
2020-01-14 03:04:17 +00:00
|
|
|
<!-- Example: When "Adding a function to do X", explain why it is necessary to have a way to do X. -->
|
2018-05-30 16:38:27 +00:00
|
|
|
|
2020-01-14 03:04:17 +00:00
|
|
|
> Screenshots/GIFs
|
2018-05-30 16:38:27 +00:00
|
|
|
|
2020-01-14 03:04:17 +00:00
|
|
|
<!-- Add images/recordings to better visualize the change: expected/current behviour -->
|
