accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2025-01-09 08:30:39 +00:00
Code Issues Releases Activity

chore: consistency in app-cache messages

Browse Source
This commit is contained in:
18alantom 2024-05-06 13:21:07 +05:30
parent 6f074a7b3e
commit 1f0d8ab5f5
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bench/app.py
View File

@ -366,15 +366,21 @@ class App(AppMeta):
if app_path.is_dir(): if app_path.is_dir():
shutil.rmtree(app_path) shutil.rmtree(app_path)
click.secho(f"Bench app-cache: getting {self.app_name} from cache", fg="yellow") click.secho(
f"Bench app-cache: extracting {self.app_name} from {cache_path.as_posix()}",
)
mode = "r:gz" if cache_path.suffix.endswith(".tgz") else "r" mode = "r:gz" if cache_path.suffix.endswith(".tgz") else "r"
with tarfile.open(cache_path, mode) as tar: with tarfile.open(cache_path, mode) as tar:
extraction_filter = get_app_cache_extract_filter(count_threshold=150_000) extraction_filter = get_app_cache_extract_filter(count_threshold=150_000)
try: try:
tar.extractall(app_path.parent, filter=extraction_filter) tar.extractall(app_path.parent, filter=extraction_filter)
click.secho(
f"Bench app-cache: extraction succeeded for {self.app_name}",
fg="green",
)
except Exception: except Exception:
message = f"Bench app-cache: extraction failed for {self.app_name}, skipping cache" message = f"Bench app-cache: extraction failed for {self.app_name}"
click.secho( click.secho(
message, message,
fg="yellow", fg="yellow",
@ -397,7 +403,7 @@ class App(AppMeta):
cache_path = self.get_app_cache_temp_path(compress_artifacts) cache_path = self.get_app_cache_temp_path(compress_artifacts)
mode = "w:gz" if compress_artifacts else "w" mode = "w:gz" if compress_artifacts else "w"
message = f"Bench app-cache: caching {self.app_name} app directory" message = f"Bench app-cache: caching {self.app_name}"
if compress_artifacts: if compress_artifacts:
message += " (compressed)" message += " (compressed)"
click.secho(message) click.secho(message)
@ -414,10 +420,14 @@ class App(AppMeta):
unlink_no_throw(hashed_path) unlink_no_throw(hashed_path)
cache_path.rename(hashed_path) cache_path.rename(hashed_path)
click.secho(
f"Bench app-cache: caching succeeded for {self.app_name} into {hashed_path.as_posix()}",
fg="green",
)
success = True success = True
except Exception as exc: except Exception as exc:
log(f"Bench app-cache: failed to cache {app_path} {exc}", level=3) log(f"Bench app-cache: caching failed for {self.app_name} {exc}", level=3)
success = False success = False
finally: finally:
os.chdir(cwd) os.chdir(cwd)