accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2025-01-09 08:30:39 +00:00
Code Issues Releases Activity

refactor: Exceptions, variables with pylint

Browse Source
This commit is contained in:
Gavin D'souza 2022-08-03 16:04:21 +05:30
parent 2c5c28bbe2
commit 4014f7349d
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bench/patches/v5/fix_user_permissions.py
View File

@ -13,6 +13,7 @@ from bench.utils import exec_cmd, get_bench_name, get_cmd_output
def is_sudoers_set(): def is_sudoers_set():
"""Check if bench sudoers is set""" """Check if bench sudoers is set"""
cmd = ["sudo", "-n", "bench"] cmd = ["sudo", "-n", "bench"]
bench_warn = False
with open(os.devnull, "wb") as f: with open(os.devnull, "wb") as f:
return_code_check = not subprocess.call(cmd, stdout=f) return_code_check = not subprocess.call(cmd, stdout=f)

9
bench/utils/__init__.py
View File

@ -63,9 +63,10 @@ def is_valid_frappe_branch(frappe_path: str, frappe_branch: str):
:type frappe_branch: str :type frappe_branch: str
:raises InvalidRemoteException: branch for this repo doesn't exist :raises InvalidRemoteException: branch for this repo doesn't exist
""" """
import git from git.cmd import Git
from git.exc import GitCommandError
g = git.cmd.Git() g = Git()
if frappe_branch: if frappe_branch:
try: try:
@ -74,8 +75,8 @@ def is_valid_frappe_branch(frappe_path: str, frappe_branch: str):
raise InvalidRemoteException( raise InvalidRemoteException(
f"Invalid branch or tag: {frappe_branch} for the remote {frappe_path}" f"Invalid branch or tag: {frappe_branch} for the remote {frappe_path}"
) )
except git.exc.GitCommandError: except GitCommandError as e:
raise InvalidRemoteException(f"Invalid frappe path: {frappe_path}") raise InvalidRemoteException(f"Invalid frappe path: {frappe_path}") from e
def log(message, level=0, no_log=False): def log(message, level=0, no_log=False):

2
bench/utils/bench.py
View File

@ -280,7 +280,7 @@ def restart_supervisor_processes(bench_path=".", web_workers=False):
sudo = "" sudo = ""
try: try:
supervisor_status = get_cmd_output("supervisorctl status", cwd=bench_path) supervisor_status = get_cmd_output("supervisorctl status", cwd=bench_path)
except Exception as e: except subprocess.CalledProcessError as e:
if e.returncode == 127: if e.returncode == 127:
log("restart failed: Couldn't find supervisorctl in PATH", level=3) log("restart failed: Couldn't find supervisorctl in PATH", level=3)
return return