From 5b1b84bc5f8938f48d4bc2c25e64b55c10ac0660 Mon Sep 17 00:00:00 2001 From: saxenabhishek Date: Mon, 31 Jan 2022 19:14:16 +0530 Subject: [PATCH 1/2] fix: use frappe13 in py 3.7 --- bench/tests/test_base.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/bench/tests/test_base.py b/bench/tests/test_base.py index 75b1646c..4c5b6889 100644 --- a/bench/tests/test_base.py +++ b/bench/tests/test_base.py @@ -14,10 +14,14 @@ from bench.utils import paths_in_bench, exec_cmd from bench.utils.system import init from bench.bench import Bench -if sys.version_info.major == 2: - FRAPPE_BRANCH = "version-12" -else: - FRAPPE_BRANCH = "develop" +PYTHON_VER = sys.version_info + +FRAPPE_BRANCH = "version-12" +if PYTHON_VER.major == 3: + if PYTHON_VER.minor in [6, 7]: + FRAPPE_BRANCH = "version-13" + else: + FRAPPE_BRANCH = "develop" class TestBenchBase(unittest.TestCase): def setUp(self): From c66283dd08e7162fafbe99be8a331e405b6fe679 Mon Sep 17 00:00:00 2001 From: saxenabhishek Date: Sat, 5 Feb 2022 01:49:11 +0530 Subject: [PATCH 2/2] test: `test_switch_to_branch()` which is lower --- bench/tests/test_init.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/bench/tests/test_init.py b/bench/tests/test_init.py index 331de422..52c23282 100755 --- a/bench/tests/test_init.py +++ b/bench/tests/test_init.py @@ -151,15 +151,21 @@ class TestBenchInit(TestBenchBase): bench_path = os.path.join(self.benches_path, "test-bench") app_path = os.path.join(bench_path, "apps", "frappe") - successful_switch = not exec_cmd("bench switch-to-branch version-13 frappe --upgrade", cwd=bench_path) + # * chore: change to 14 when avalible + prevoius_branch = "version-13" + if FRAPPE_BRANCH != "develop": + # assuming we follow `version-#` + prevoius_branch = f"version-{int(FRAPPE_BRANCH.split('-')[1]) - 1}" + + successful_switch = not exec_cmd(f"bench switch-to-branch {prevoius_branch} frappe --upgrade", cwd=bench_path) app_branch_after_switch = str(git.Repo(path=app_path).active_branch) if successful_switch: - self.assertEqual("version-13", app_branch_after_switch) + self.assertEqual(prevoius_branch, app_branch_after_switch) - successful_switch = not exec_cmd("bench switch-to-branch develop frappe --upgrade", cwd=bench_path) + successful_switch = not exec_cmd(f"bench switch-to-branch {FRAPPE_BRANCH} frappe --upgrade", cwd=bench_path) app_branch_after_second_switch = str(git.Repo(path=app_path).active_branch) if successful_switch: - self.assertEqual("develop", app_branch_after_second_switch) + self.assertEqual(FRAPPE_BRANCH, app_branch_after_second_switch) if __name__ == '__main__':