accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2025-01-10 17:24:41 +00:00
Code Issues Releases Activity

feat: alternative request to validate branch

Browse Source
This commit is contained in:
saxenabhishek 2022-03-14 05:17:08 +05:30
parent bb16b73358
commit 8dd92c32b1
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bench/utils/__init__.py
View File

@ -50,15 +50,22 @@ def is_frappe_app(directory: str) -> bool:
def is_valid_frappe_branch(frappe_path, frappe_branch): def is_valid_frappe_branch(frappe_path, frappe_branch):
if "http" in frappe_path: if "http" in frappe_path and frappe_branch:
frappe_path = frappe_path.replace(".git", "") frappe_path = frappe_path.replace(".git", "")
try: try:
owner, repo = frappe_path.split("/")[3], frappe_path.split("/")[4] owner, repo = frappe_path.split("/")[3], frappe_path.split("/")[4]
except IndexError: except IndexError:
raise InvalidRemoteException raise InvalidRemoteException
git_api = f"https://api.github.com/repos/{owner}/{repo}/branches" git_api_req = f"https://api.github.com/repos/{owner}/{repo}/branches"
res = requests.get(git_api).json() res = requests.get(git_api_req).json()
if "message" in res or (frappe_branch and frappe_branch not in [x["name"] for x in res]):
if "message" in res:
# slower alternative with no rate limit
github_req = f'https://github.com/{owner}/{repo}/tree/{frappe_branch}'
if requests.get(github_req).status_code != 200:
raise InvalidRemoteException
elif frappe_branch not in [x["name"] for x in res]:
raise InvalidRemoteException raise InvalidRemoteException