accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2025-01-09 16:36:25 +00:00
Code Issues Releases Activity

refactor: bench.utils.exec_cmd

Browse Source 
Refactoring the official way to run any commands through bench. Added a
way to pass on envvars, and use the new log API w click ;)
This commit is contained in:
Gavin D'souza 2021-10-30 02:44:00 +05:30
parent ba289fba25
commit 93e5655570
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bench/utils.py
View File

@ -282,14 +282,17 @@ def clone_apps_from(bench_path, clone_from, update_app=True):
setup_app(app) setup_app(app)
def exec_cmd(cmd, cwd='.'): def exec_cmd(cmd, cwd='.', env=None):
import shlex if env:
print(f"{color.silver}$ {cmd}{color.nc}") env.update(os.environ.copy())
click.secho(f"$ {cmd}", fg='bright_black')
cwd_info = f"cd {cwd} && " if cwd != "." else "" cwd_info = f"cd {cwd} && " if cwd != "." else ""
cmd_log = f"{cwd_info}{cmd}" cmd_log = f"{cwd_info}{cmd}"
logger.debug(cmd_log) logger.debug(cmd_log)
cmd = shlex.split(cmd) cmd = split(cmd)
return_code = subprocess.call(cmd, cwd=cwd, universal_newlines=True) return_code = subprocess.call(cmd, cwd=cwd, universal_newlines=True, env=env)
if return_code: if return_code:
logger.warning(f"{cmd_log} executed with exit code {return_code}") logger.warning(f"{cmd_log} executed with exit code {return_code}")