accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2024-09-25 05:19:04 +00:00
Code Issues Releases Activity

fix(remove-app): Use App.name instead of App.repo for consistent App name

Browse Source
This commit is contained in:
gavin 2022-05-19 12:58:24 +05:30
parent 117d456b16
commit a3b859bf50
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bench/app.py
View File

@ -180,7 +180,7 @@ class App(AppMeta):
@step(title="Archiving App {repo}", success="App {repo} Archived") @step(title="Archiving App {repo}", success="App {repo} Archived")
def remove(self): def remove(self):
active_app_path = os.path.join("apps", self.repo) active_app_path = os.path.join("apps", self.name)
archived_path = os.path.join("archived", "apps") archived_path = os.path.join("archived", "apps")
archived_name = get_available_folder_name(f"{self.repo}-{date.today()}", archived_path) archived_name = get_available_folder_name(f"{self.repo}-{date.today()}", archived_path)
archived_app_path = os.path.join(archived_path, archived_name) archived_app_path = os.path.join(archived_path, archived_name)
@ -224,7 +224,7 @@ class App(AppMeta):
@step(title="Uninstalling App {repo}", success="App {repo} Uninstalled") @step(title="Uninstalling App {repo}", success="App {repo} Uninstalled")
def uninstall(self): def uninstall(self):
self.bench.run(f"{self.bench.python} -m pip uninstall -y {self.repo}") self.bench.run(f"{self.bench.python} -m pip uninstall -y {self.name}")
def _get_dependencies(self): def _get_dependencies(self):
from bench.utils.app import get_required_deps, required_apps_from_hooks from bench.utils.app import get_required_deps, required_apps_from_hooks