accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2025-01-27 08:18:25 +00:00
Code Issues Releases Activity

fix: Don't handle BaseExceptions

Browse Source
This commit is contained in:
Gavin D'souza 2022-03-17 11:41:57 +05:30
parent d33d987b2c
commit ad000f1be7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bench/app.py
View File

@ -425,7 +425,7 @@ def install_resolved_deps(
try: try:
installed_branch = bench.apps.states[repo_name]["resolution"]["branch"].strip() installed_branch = bench.apps.states[repo_name]["resolution"]["branch"].strip()
except: except Exception:
installed_branch = ( installed_branch = (
subprocess. subprocess.
check_output("git rev-parse --abbrev-ref HEAD", shell=True, cwd=path_to_app) check_output("git rev-parse --abbrev-ref HEAD", shell=True, cwd=path_to_app)
@ -451,7 +451,7 @@ def install_resolved_deps(
is_compatible = default_branch == installed_branch is_compatible = default_branch == installed_branch
else: else:
is_compatible = installed_branch == app.tag is_compatible = installed_branch == app.tag
except: except Exception:
is_compatible = False is_compatible = False
prefix = 'C' if is_compatible else 'Inc' prefix = 'C' if is_compatible else 'Inc'