accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2024-09-27 22:39:03 +00:00
Code Issues Releases Activity

chore: remove proxy method: setup_details_from_git_url (#1546)

Browse Source
This commit is contained in:
Sabu Siyad 2024-03-10 13:46:00 +05:30 committed by GitHub
parent b12ac648fb
commit d728b80883
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bench/app.py
View File

@ -101,7 +101,7 @@ class AppMeta:
# fetch meta for repo from remote git server - traditional get-app url # fetch meta for repo from remote git server - traditional get-app url
elif is_git_url(self.name): elif is_git_url(self.name):
self.is_url = True self.is_url = True
self._setup_details_from_git_url() self.__setup_details_from_git()
# fetch meta from new styled name tags & first party apps on github # fetch meta from new styled name tags & first party apps on github
else: else:
@ -116,7 +116,7 @@ class AppMeta:
# If app is a git repo # If app is a git repo
self.git_repo = git.Repo(self.mount_path) self.git_repo = git.Repo(self.mount_path)
try: try:
self._setup_details_from_git_url(self.git_repo.remotes[0].url) self.__setup_details_from_git(self.git_repo.remotes[0].url)
if not (self.branch or self.tag): if not (self.branch or self.tag):
self.tag = self.branch = self.git_repo.active_branch.name self.tag = self.branch = self.git_repo.active_branch.name
except IndexError: except IndexError:
@ -131,9 +131,6 @@ class AppMeta:
self.org, self.repo, self.tag = fetch_details_from_tag(self.name, using_cached) self.org, self.repo, self.tag = fetch_details_from_tag(self.name, using_cached)
self.tag = self.tag or self.branch self.tag = self.tag or self.branch
def _setup_details_from_git_url(self, url=None):
return self.__setup_details_from_git(url)
def __setup_details_from_git(self, url=None): def __setup_details_from_git(self, url=None):
name = url if url else self.name name = url if url else self.name
if name.startswith("git@") or name.startswith("ssh://"): if name.startswith("git@") or name.startswith("ssh://"):