From db13ce3732eadd0438d1f3c1e9e7b47abf8d322c Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Thu, 4 Aug 2022 12:14:07 +0530 Subject: [PATCH] fix!: Don't update supervisord conf - instead just suggest --- bench/config/supervisor.py | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/bench/config/supervisor.py b/bench/config/supervisor.py index d4d6b14e..42c7a1e3 100644 --- a/bench/config/supervisor.py +++ b/bench/config/supervisor.py @@ -79,10 +79,11 @@ def get_supervisord_conf(): return possibility -def update_supervisord_config(user=None, yes=False): +def update_supervisord_config(user=None): """From bench v5.x, we're moving to supervisor running as user""" + # i don't think bench should be responsible for this but we're way past this now... + # removed updating supervisord conf & reload in Aug 2022 - gavin@frappe.io import configparser - from bench.config.production_setup import service if not user: user = getpass.getuser() @@ -125,20 +126,3 @@ def update_supervisord_config(user=None, yes=False): print( f"Update your {supervisord_conf} with the following values:\n[{section}]\n{contents}" ) - return - - if not yes: - click.confirm( - f"{supervisord_conf} will be updated with the following values:\n{supervisord_conf_changes}\nDo you want to continue?", - abort=True, - ) - - try: - with open(supervisord_conf, "w") as f: - config.write(f) - logger.log(f"Updated supervisord.conf at '{supervisord_conf}'") - except Exception as e: - logger.log(f"Updating supervisord.conf failed due to '{e}'") - - # Reread supervisor configuration, reload supervisord and supervisorctl, restart services that were started - service("supervisor", "reload")