From f1ea6fce3ffeae0a311beecad1d514d003875548 Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Tue, 18 Feb 2020 17:07:26 +0530 Subject: [PATCH] chore: drop auto update bench via cronjob --- bench/commands/config.py | 7 ------- bench/commands/make.py | 4 +--- bench/commands/setup.py | 7 ------- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/bench/commands/config.py b/bench/commands/config.py index 7dbaaed9..bf912ed1 100644 --- a/bench/commands/config.py +++ b/bench/commands/config.py @@ -14,12 +14,6 @@ def config(): pass -@click.command('auto_update', help='Enable/Disable auto update for bench') -@click.argument('state', type=click.Choice(['on', 'off'])) -def config_auto_update(state): - update_config({'auto_update': state == 'on'}) - - @click.command('restart_supervisor_on_update', help='Enable/Disable auto restart of supervisor processes') @click.argument('state', type=click.Choice(['on', 'off'])) def config_restart_supervisor_on_update(state): @@ -90,7 +84,6 @@ def remove_common_config(keys): put_config(common_site_config) -config.add_command(config_auto_update) config.add_command(config_update_bench_on_update) config.add_command(config_restart_supervisor_on_update) config.add_command(config_restart_systemd_on_update) diff --git a/bench/commands/make.py b/bench/commands/make.py index f6ba1377..5f6e236f 100755 --- a/bench/commands/make.py +++ b/bench/commands/make.py @@ -13,11 +13,10 @@ import click @click.option('--clone-without-update', is_flag=True, help="copy repos from path without update") @click.option('--no-procfile', is_flag=True, help="Pull changes in all the apps in bench") @click.option('--no-backups',is_flag=True, help="Run migrations for all sites in the bench") -@click.option('--no-auto-update',is_flag=True, help="Build JS and CSS artifacts for the bench") @click.option('--skip-redis-config-generation', is_flag=True, help="Skip redis config generation if already specifying the common-site-config file") @click.option('--skip-assets',is_flag=True, default=False, help="Do not build assets") @click.option('--verbose',is_flag=True, help="Verbose output during install") -def init(path, apps_path, frappe_path, frappe_branch, no_procfile, no_backups, no_auto_update, clone_from, verbose, skip_redis_config_generation, clone_without_update, ignore_exist=False, skip_assets=False, python='python3'): +def init(path, apps_path, frappe_path, frappe_branch, no_procfile, no_backups, clone_from, verbose, skip_redis_config_generation, clone_without_update, ignore_exist=False, skip_assets=False, python='python3'): from bench.utils import init, log try: @@ -26,7 +25,6 @@ def init(path, apps_path, frappe_path, frappe_branch, no_procfile, no_backups, n apps_path=apps_path, no_procfile=no_procfile, no_backups=no_backups, - no_auto_update=no_auto_update, frappe_path=frappe_path, frappe_branch=frappe_branch, verbose=verbose, diff --git a/bench/commands/setup.py b/bench/commands/setup.py index 440e1f5e..c83633b5 100755 --- a/bench/commands/setup.py +++ b/bench/commands/setup.py @@ -75,12 +75,6 @@ def setup_production(user, yes=False): setup_production(user=user, yes=yes) -@click.command("auto-update", help="Add cronjob for bench auto update") -def setup_auto_update(): - from bench.utils import setup_auto_update - setup_auto_update() - - @click.command("backups", help="Add cronjob for bench backups") def setup_backups(): from bench.utils import setup_backups @@ -309,7 +303,6 @@ setup.add_command(setup_redis) setup.add_command(setup_letsencrypt) setup.add_command(setup_wildcard_ssl) setup.add_command(setup_production) -setup.add_command(setup_auto_update) setup.add_command(setup_backups) setup.add_command(setup_env) setup.add_command(setup_procfile)