accounting/bench
2
0
Fork 0
mirror of https://github.com/frappe/bench.git synced 2025-01-22 22:58:31 +00:00
Code Issues Releases Activity

Merge pull request #1598 from akhilnarang/exception-to-echo

Browse Source 
refactor: change some exceptions to simple echo + exits
This commit is contained in:
Akhil Narang 2024-11-25 14:10:44 +05:30 committed by GitHub
commit fcf7210f13
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bench/app.py
View File

@ -23,7 +23,6 @@ import semantic_version as sv
# imports - module imports # imports - module imports
import bench import bench
from bench.exceptions import NotInBenchDirectoryError
from bench.utils import ( from bench.utils import (
UNSET_ARG, UNSET_ARG,
fetch_details_from_tag, fetch_details_from_tag,
@ -706,10 +705,12 @@ def get_app(
if not is_bench_directory(bench_path): if not is_bench_directory(bench_path):
if not init_bench: if not init_bench:
raise NotInBenchDirectoryError( click.secho(
f"{os.path.realpath(bench_path)} is not a valid bench directory. " f"{os.path.realpath(bench_path)} is not a valid bench directory. "
"Run with --init-bench if you'd like to create a Bench too." "Run with --init-bench if you'd like to create a Bench too.",
fg="red",
) )
sys.exit(1)
from bench.utils.system import init from bench.utils.system import init
@ -851,9 +852,11 @@ def install_resolved_deps(
def new_app(app, no_git=None, bench_path="."): def new_app(app, no_git=None, bench_path="."):
if bench.FRAPPE_VERSION in (0, None): if bench.FRAPPE_VERSION in (0, None):
raise NotInBenchDirectoryError( click.secho(
f"{os.path.realpath(bench_path)} is not a valid bench directory." f"{os.path.realpath(bench_path)} is not a valid bench directory.",
fg="red",
) )
sys.exit(1)
# For backwards compatibility # For backwards compatibility
app = app.lower().replace(" ", "_").replace("-", "_") app = app.lower().replace(" ", "_").replace("-", "_")

5
bench/exceptions.py
View File

@ -33,10 +33,5 @@ class CannotUpdateReleaseBench(ValidationError):
class FeatureDoesNotExistError(CommandFailedError): class FeatureDoesNotExistError(CommandFailedError):
pass pass
class NotInBenchDirectoryError(Exception):
pass
class VersionNotFound(Exception): class VersionNotFound(Exception):
pass pass