2
0
mirror of https://github.com/frappe/bench.git synced 2024-06-15 14:42:22 +00:00
Commit Graph

1388 Commits

Author SHA1 Message Date
18alantom
319809d2df fix: add useforsecurity with fallback for <3.9 2024-05-08 10:15:39 +05:30
18alantom
fbdae3912a chore: fix app-cache format 2024-05-06 15:48:08 +05:30
18alantom
d3ca36d596 chore: deprecate 3.7 support 2024-05-06 15:35:24 +05:30
18alantom
1f0d8ab5f5 chore: consistency in app-cache messages 2024-05-06 13:21:07 +05:30
18alantom
6f074a7b3e fix: update pre url coercion check 2024-05-06 13:11:51 +05:30
18alantom
efb51712d9 fix: check md5 when fetching from cache 2024-05-06 12:58:16 +05:30
18alantom
8854551eee chore: update secho messages 2024-05-06 12:28:38 +05:30
18alantom
16f89067c6 fix: calc md5 for app cache 2024-05-06 12:23:18 +05:30
Fritz
1751b2db5b
fix: Switched to native GIT way to lookup branch names (#1553) 2024-04-29 16:22:19 +05:30
Raffael Meyer
5a0922d991
fix: add jammy package for Ubuntu 22 (#1549) 2024-04-15 20:35:15 +05:30
Sabu Siyad
d728b80883
chore: remove proxy method: setup_details_from_git_url (#1546) 2024-03-10 13:46:00 +05:30
Ankush Menat
014358d02a fix!: Unconditionally assume frappe_cmd 2024-02-23 21:09:55 +05:30
Ankush Menat
8db23dd230 perf: Avoid use of glob for fetching python executable
glob on env/**/bin is slowest operation in terms of overhead on CLI.
2024-02-23 21:09:23 +05:30
David Arnold
7c64aa3d94
fix(build): support pyproject version (#1502)
* fix(build): support pyproject version

* refactor: use util for parsing pyproject

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-02-23 20:50:21 +05:30
18alantom
aa12aabb26 fix: ignore org check fail if using cache 2024-02-21 16:24:16 +05:30
Ankush Menat
ab9b6172a4
feat: bench validate-dependencies command (#1534)
This validates all `frappe-dependencies` and exits with 1 if any of
specifications fail.

This will be internal feature for FC for now. If this works well we can
make the validation fail during install-app itself without requiring any
additional command/steps.
2024-02-07 18:27:54 +05:30
Ankush Menat
1a421758a8
fix: Check yarn files during install (#1533)
We observed that in some cases files are missing when yarn reuses them
from cache. Not sure what's causing it but checking files seems to at
least fix it. This is probably some yarn bug.
2024-02-07 13:06:00 +05:30
Ankush Menat
f5ab0459ec
fix: RQ crashes on Mac (#1529)
It will still crash if spawned outside of procfile. This is just a
workaround for developers who are starting out and won't be able to
figure out the crash. You can also add env variables in your RC file.

Permanent fix: Use Linux.
2024-02-03 17:39:24 +05:30
18alantom
54b514b749 fix: coerce git_url to app_name
- allows get-app command to be the same
- prevents checking and fetching of local remote
- prevents docker layer cache miss
2024-02-02 16:36:29 +05:30
18alantom
863dde6acd chore: indicate on cache extraction failure 2024-02-01 15:00:20 +05:30
18alantom
d8ce1b3cb4 fix: increase tar file limit
including node_modules in tar blob causes
file counts to be consistently above 10k
eg:
- gameplan: 25,269
- hrms: 32,369
2024-02-01 14:57:17 +05:30
18alantom
d93656e8d9 fix: check frappe-deps during get-app 2024-02-01 12:12:27 +05:30
18alantom
9988b8356b fix: del node_modules if frappe supports app_cache 2024-01-31 17:54:54 +05:30
18alantom
3502c776c0 fix: version check before AbsoluteLinkError 2024-01-24 12:11:04 +05:30
18alantom
80f2e70af6 fix: version check before data_filter import
- better error handling if untar fails
2024-01-24 11:58:03 +05:30
18alantom
23bd717d7b feat: comment out unsupported typing 2024-01-23 17:26:08 +05:30
18alantom
e8ea98552c fix: add safety filter for untarring 2024-01-23 17:20:16 +05:30
Alan
8c125c6f62
Merge branch 'develop' into get-app-cache 2024-01-23 15:07:13 +05:30
18alantom
4e170a2042 fix: remove rem check from app-cache --clear 2024-01-19 19:28:57 +05:30
18alantom
c5ec4f7528 chore: rename commit-hash to cache-key 2024-01-19 19:18:13 +05:30
18alantom
42ac015bff feat: add bench app-cache helper command 2024-01-19 14:59:28 +05:30
18alantom
30f301e3ff fix: wrap tarfile with error handling
- ensure return to cwd after tarring
2024-01-18 18:06:08 +05:30
18alantom
0e2e8b4da3 fix: remove unused nodemodules before caching 2024-01-18 17:44:25 +05:30
18alantom
683a421e43 refactor: use env to trigger using-cached flag
Click supports pulling args from an envvar if it is present,
this would be quicker and cleaner than calling a dummy command
to check if the feature is supported
2024-01-18 16:23:04 +05:30
18alantom
d177d8ff63 fix: check if installed FF supports use-cached 2024-01-18 13:04:50 +05:30
Ankush Menat
8d3270e4ad perf: add Cache-Control header for assets
closes https://github.com/frappe/bench/issues/1154
2024-01-17 20:38:47 +05:30
18alantom
10bb5a4794 fix: update install_app with using_cached flag 2024-01-15 15:56:45 +05:30
Akhil Narang
deadc7c7c2
feat: set startretries in supervisor configuration
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-15 14:23:24 +05:30
18alantom
7bcea6099d fix: prevent circular dependency
- put check_existing_dir back in its place
2024-01-15 13:40:26 +05:30
Akhil Narang
9460a46ac3
chore: simplify output of bench setup supervisor when supervisor isn't installed
Seeing the whole stacktrace isn't too useful here

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-15 13:34:58 +05:30
Akhil Narang
7a89ccd53a
fix: wrong help string
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-15 13:33:49 +05:30
18alantom
87d4aa3b10 feat: cache get-app artifacts by commit_hash 2024-01-15 12:02:47 +05:30
Himanshu Shivhare
209f716b5b
chore: fix typo (#1517) 2024-01-11 14:13:18 +05:30
Akhil Narang
839bd7c630
feat(supervisor): restart each group separately
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-07 16:12:10 +05:30
Ankush Menat
a834d864bb
Merge pull request #1486 from revant/fix-verbose
fix: pass verbose to yarn or npm install
2023-11-29 11:19:45 +05:30
Ankush Menat
2ec0c0a95a fix: more reliable gunicorn restart
killasgroup will ensure that all child processes die even if gunicorn
fails to do it. This isn't truly required because stopwaitsecs and
gunicorn graceful timeout work fine. In any case, if supervisor has to
send SIGKILL, it better send it to entire process group.
2023-11-03 21:38:47 +05:30
Ankush Menat
255c9301e9
Merge pull request #1494 from frappe/dev_bench
feat: flag to setup bench with developer mode enabled
2023-11-02 19:45:27 +05:30
Ankush Menat
f29e25a5d2 feat: flag to setup bench with developer mode enabled
Dev dependencies are not installed if developer_mode is not enabled.
When creating a new bench it's not possible to modify this config
upfront, so offer a flag to do it instead.

Note:
- Disabled by default.
- Very few people need this, those who write and run tests locally primarily.
- You mostly should not do this in CI, do `bench setup requirements --dev` explicitly instead.
2023-11-02 14:28:21 +05:30
Ankush Menat
36f2194865 fix: Prevent Gunicorn child workers hangup
Problem:

- Prerequisite: long running reqeust is going on.
- `bench restart` is requested.
- supervisord sends sigterm to gunicorn master process.
- gunicorn passes it to all child table and waits for graceful shutdown (30 seconds)
- supervisord has no chill, and sends sigkill to master process in 10 seconds
- gunicorn master proesss is dead, so now child workers will keep running until they complete request which can take a really long time.
- This entire time the sites will be down.

Fix:
- Explicitly encode default graceful_timeout in config - 30 seconds.
- Make supervisor wait 10 more seconds for gunicorn to do its thing, then only send sigkill.
2023-11-02 11:40:07 +05:30
Ankush Menat
53a8fedadc fix: override X-Forwarded-For address in bench manager 2023-10-19 17:06:21 +05:30