Akhil Narang
c599ee86dd
fix: use a tuple instead of a list
...
From perflint:
bench/utils/bench.py:89:9: W8301: Use tuple instead of list for a non-mutated sequence (use-tuple-over-list)
(just needed a fix to trigger a new release)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-21 13:07:24 +05:30
18alantom
319809d2df
fix: add useforsecurity with fallback for <3.9
2024-05-08 10:15:39 +05:30
18alantom
fbdae3912a
chore: fix app-cache format
2024-05-06 15:48:08 +05:30
18alantom
efb51712d9
fix: check md5 when fetching from cache
2024-05-06 12:58:16 +05:30
18alantom
16f89067c6
fix: calc md5 for app cache
2024-05-06 12:23:18 +05:30
Fritz
1751b2db5b
fix: Switched to native GIT way to lookup branch names ( #1553 )
2024-04-29 16:22:19 +05:30
Ankush Menat
8db23dd230
perf: Avoid use of glob for fetching python executable
...
glob on env/**/bin is slowest operation in terms of overhead on CLI.
2024-02-23 21:09:23 +05:30
David Arnold
7c64aa3d94
fix(build): support pyproject version ( #1502 )
...
* fix(build): support pyproject version
* refactor: use util for parsing pyproject
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-02-23 20:50:21 +05:30
18alantom
aa12aabb26
fix: ignore org check fail if using cache
2024-02-21 16:24:16 +05:30
Ankush Menat
1a421758a8
fix: Check yarn files during install ( #1533 )
...
We observed that in some cases files are missing when yarn reuses them
from cache. Not sure what's causing it but checking files seems to at
least fix it. This is probably some yarn bug.
2024-02-07 13:06:00 +05:30
18alantom
d93656e8d9
fix: check frappe-deps during get-app
2024-02-01 12:12:27 +05:30
18alantom
9988b8356b
fix: del node_modules if frappe supports app_cache
2024-01-31 17:54:54 +05:30
18alantom
3502c776c0
fix: version check before AbsoluteLinkError
2024-01-24 12:11:04 +05:30
18alantom
80f2e70af6
fix: version check before data_filter import
...
- better error handling if untar fails
2024-01-24 11:58:03 +05:30
18alantom
23bd717d7b
feat: comment out unsupported typing
2024-01-23 17:26:08 +05:30
18alantom
e8ea98552c
fix: add safety filter for untarring
2024-01-23 17:20:16 +05:30
Alan
8c125c6f62
Merge branch 'develop' into get-app-cache
2024-01-23 15:07:13 +05:30
18alantom
4e170a2042
fix: remove rem check from app-cache --clear
2024-01-19 19:28:57 +05:30
18alantom
c5ec4f7528
chore: rename commit-hash to cache-key
2024-01-19 19:18:13 +05:30
18alantom
42ac015bff
feat: add bench app-cache helper command
2024-01-19 14:59:28 +05:30
18alantom
683a421e43
refactor: use env to trigger using-cached flag
...
Click supports pulling args from an envvar if it is present,
this would be quicker and cleaner than calling a dummy command
to check if the feature is supported
2024-01-18 16:23:04 +05:30
18alantom
d177d8ff63
fix: check if installed FF supports use-cached
2024-01-18 13:04:50 +05:30
18alantom
10bb5a4794
fix: update install_app with using_cached flag
2024-01-15 15:56:45 +05:30
18alantom
87d4aa3b10
feat: cache get-app artifacts by commit_hash
2024-01-15 12:02:47 +05:30
Akhil Narang
839bd7c630
feat(supervisor): restart each group separately
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-07 16:12:10 +05:30
Ankush Menat
a834d864bb
Merge pull request #1486 from revant/fix-verbose
...
fix: pass verbose to yarn or npm install
2023-11-29 11:19:45 +05:30
Ankush Menat
f29e25a5d2
feat: flag to setup bench with developer mode enabled
...
Dev dependencies are not installed if developer_mode is not enabled.
When creating a new bench it's not possible to modify this config
upfront, so offer a flag to do it instead.
Note:
- Disabled by default.
- Very few people need this, those who write and run tests locally primarily.
- You mostly should not do this in CI, do `bench setup requirements --dev` explicitly instead.
2023-11-02 14:28:21 +05:30
Revant Nandgaonkar
00391bfeb9
feat: pass verbose to npm install
2023-09-14 04:35:30 +05:30
Revant Nandgaonkar
346d08d30f
feat: pass verbose to yarn install
2023-09-14 04:29:58 +05:30
Ankush Menat
036cb6291e
fix: don't compile python files manually. ( #1469 )
2023-07-04 19:52:05 +05:30
Gavin D'souza
e80daf8c3e
fix: Use == for dict comparison
2023-05-31 14:00:24 +05:30
Gavin D'souza
a1d2c5226b
fix: Print failing command with CommandFailedError
...
I've seen way too many issues being faced / misunderstandings due to the
lack of "cmd"
2023-05-26 11:25:02 +05:30
gavin
c690e8e7f5
fix: Handle supervisor escalation better ( #1438 )
...
* fix: Give more meaningful context in subproc failures
* fix: Handle supervisor escalation if no exc is raised
* fix: only apply sudo if not already running as sudo
2023-02-24 15:13:36 +05:30
Ankush Menat
23eede5fd3
fix: version check backward compatibility ( #1409 )
...
This code wasn't triggering because VersionNotFound exception gets
thrown before it ever reaches to this point.
2023-01-02 16:03:33 +05:30
Ankush Menat
7a63f4f461
fix: ignore supervisor restart failures where possible ( #1400 )
...
* fix: ignore supervisor restart failures where possible
Ignores proc manager restart failure during:
- App install
- App uninstall
Reason:
- You might not have setup prod yet
- This is useful during docker image building where proc manager wont be
running **yet**.
* ci: dont fail-fast
matrix has no dependency.
2022-12-12 14:08:04 +05:30
Ankush Menat
0e59159e11
fix: dont attempt migrating to active virtualenv
2022-11-29 12:49:19 +05:30
Ankush Menat
e37df969c1
refactor(migrate_env): virtualenv -> venv
2022-11-29 12:40:11 +05:30
Ankush Menat
4f0193ca93
fix: install one app at a time, frappe first
2022-11-29 12:33:53 +05:30
Ankush Menat
61e0f4acbf
fix: correct python path for migrate_env
...
Currently it's executing env directory which would never work.
2022-11-29 12:23:49 +05:30
Ankush Menat
7f1c5ad9c6
fix: migrate_env silent failures
2022-11-29 12:23:13 +05:30
Ankush Menat
c4305fd528
style: format everything w black
2022-11-23 14:35:01 +05:30
HENRY Florian
9131ba05db
fix: use ref param instead of branch for get_required_deps (GitHub contents API) ( #1362 )
...
* fix: use ref param instead of branch
* fix: use ref param instead of branch
* chore: unintentional changes from web editor
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-08-28 17:59:10 +05:30
HENRY Florian
589f7a400e
fix: bad URL in raw.githubusercontent.com ( #1363 )
2022-08-28 17:06:06 +05:30
Ankush Menat
b6b9481b7b
fix(DX): make warnings go to stderr
2022-08-10 11:42:34 +05:30
Sagar Vora
dc047a5e7d
fix: dont use glob pattern for python
exec
2022-08-07 01:36:16 +05:30
Gavin D'souza
bbf0169994
fix(nginx): Allow specifying log_format setting
...
Changes
* Added sugared option class that allows setting options only if another
is set
* setup nginx command allows to set logging level & log_format options
2022-08-04 16:00:27 +05:30
Gavin D'souza
4014f7349d
refactor: Exceptions, variables with pylint
2022-08-03 16:04:21 +05:30
Gavin D'souza
2c5c28bbe2
fix: Remove broken import path
2022-08-03 15:54:44 +05:30
gavin
18a954b88c
Merge pull request #1349 from gavindsouza/frappe-cmd-cache-bye
...
fix: Remove frappe cmd caching in .bench.cmd
2022-08-02 14:38:37 +05:30
Gavin D'souza
f77352966b
fix: Remove frappe cmd caching in .bench.cmd
2022-08-02 13:14:55 +05:30