gavin
aefdc3bb47
Merge pull request #1197 from gavindsouza/misc-fixes
...
fix: Misc fixes
2021-09-09 16:40:56 +05:30
Gavin D'souza
6fd3ad738b
fix(command_cache): Return iterable as fallback
2021-09-09 16:05:42 +05:30
Gavin D'souza
b35af193d3
chore: Remove unnecessary returns, re-order cli resolution
...
Changes suggested by LGTM https://lgtm.com/projects/g/frappe/bench/rev/pr-560978725461013796d605b409ffc5c85c774829
2021-09-09 14:56:32 +05:30
Gavin D'souza
a015501699
fix: Return fallback list in cached_frappe_commands
2021-09-09 13:54:35 +05:30
Gavin D'souza
6160ff48ab
style: Black
2021-09-09 13:54:19 +05:30
Gavin D'souza
552b935f6b
fix: Always set return code via cli
2021-09-09 13:20:26 +05:30
Gavin D'souza
a94ea19bf4
fix: Hit command cache before fetching all commands
2021-09-09 13:19:44 +05:30
Francisco Roldan
e12f53d1a5
feat: added option to provide custom queues
2021-08-30 12:35:53 -03:00
gavin
d467cf54c1
Merge pull request #1007 from Thunderbottom/referrer-policy
...
fix: set referrer-policy header in nginx config
2021-08-30 13:01:30 +05:30
gavin
beb14c8681
Merge branch 'develop' into referrer-policy
2021-08-30 12:38:59 +05:30
Abhishek Balam
6137086e03
feat: Set default version for easy install to v13 ( #1189 )
...
* feat: set default version for easy install to v13
* fix: python version based version picking fixed and reverted changes to node version in installation script
* fix: revert test version
Co-authored-by: gavin <gavin18d@gmail.com>
2021-08-30 12:29:09 +05:30
gavin
06cfd76a6b
Merge pull request #1190 from leela/redis-config
...
feat: Redis ACL config is added to conf templates
2021-07-20 12:59:44 +05:30
leela
46e66226c2
feat: Redis ACL config is added to conf templates
2021-07-20 06:22:15 +05:30
gavin
5eb71ed024
docs: Update README info about easy install script
...
Bench playbooks haven't been updated with Frappe Version 13 requirements. And they are untested at this point. The only up to date methods of install are [Frappe Docker](https://github.com/frappe/frappe_docker ) and [the installation guide in Frappe Docs](https://frappeframework.com/docs/user/en/installation ).
2021-07-08 13:55:31 +05:30
gavin
db4627bb92
Merge pull request #1186 from rovertzxd/fix-ssl-nginx-directive-deprecation
...
fix: ssl nginx directive deprecation
2021-07-07 11:24:36 +05:30
Roberto Murguia
a514a0e97b
fix: ssl nginx directive deprecation
2021-06-15 09:35:04 -05:00
gavin
a7fec5c4f5
Merge pull request #1156 from gavindsouza/perf-remove-app
...
perf: Faster bench remove-app
2021-05-13 14:56:25 +05:30
Gavin D'souza
5e0d46db24
Merge branch 'develop' into perf-remove-app
2021-05-13 14:18:15 +05:30
gavin
656eeca343
Merge pull request #1170 from gavindsouza/f-strings
...
chore: Drop support for < Py3.6
2021-05-13 14:00:50 +05:30
Gavin D'souza
753e36d433
fix: Revert print compatibility import
2021-05-11 19:57:24 +05:30
Gavin D'souza
72e6795f50
chore: Drop Circle CI config
2021-05-11 19:25:10 +05:30
Gavin D'souza
54d48f61a3
fix: Remove PY2 compatibility code
...
* Set Python requires Python 3.6+ but < Py4
* Remove six from dependencies
* Use click.confirm instead of self implemented confirm code
* Fix imports for 3.6+ compatibility
References for updated imports:
* https://docs.python.org/3/library/configparser.html
* https://docs.python.org/3/library/urllib.request.html#legacy-interface
* https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlparse
* https://docs.python.org/3/library/importlib.html#importlib.reload
2021-05-11 12:01:32 +05:30
Gavin D'souza
5d563f23ab
style: Use f-strings instead of old string formatting methods
...
These changes are valid only for Py3.6+ and will remove bench CLI
support for Python 3.5 and lesser.
* Converted to f-strings using flynt
* Manual conversion of failed cases
* Simplification of logic
2021-05-11 11:30:27 +05:30
Gavin D'souza
dcdb15d471
fix: Handle command execution failures
2021-05-10 19:10:06 +05:30
gavin
0c21718f7a
Merge branch 'develop' into perf-remove-app
2021-05-10 18:51:57 +05:30
gavin
ac4c0efa3b
Merge pull request #1169 from gavindsouza/bench-update-no-reset
...
fix: Bench update no reset
2021-05-10 18:51:39 +05:30
Gavin D'souza
01abc561e0
fix: Added warning for unshallow without --reset
2021-05-10 17:35:31 +05:30
Gavin D'souza
f46126ce2b
chore: Remove deprecated option from config template
2021-05-10 14:51:52 +05:30
Gavin D'souza
096c2cfe6b
fix: Show step titles while running operations
2021-05-10 14:51:14 +05:30
Gavin D'souza
4cadf2c719
fix: Unshallow clone if update without --reset
...
If an unshallow clone has to be updated, the only way to update it
without a reset will require an unshallow. This is because there may be
uncommitted or committed changes in any of the apps, although unfavoured
should be handled safely. The only way to update such repos is via the
user configured settings..or a ff only merge.
2021-05-10 14:45:46 +05:30
Gavin D'souza
ebc3cebd19
perf: Faster bench remove-app
...
Biggest bottleneck is in the validation stage which checks if the app is
installed on any existing sites on the bench. instead of triggering
multiple list-apps for each sites, do one for all.
2021-05-05 16:34:10 +05:30
gavin
70c9c17f63
docs(README): Update broken ref link
2021-04-27 16:52:49 +05:30
Gavin D'souza
7035366663
ci: Trigger branch checks
2021-04-27 15:48:28 +05:30
gavin
9435af4d6c
Merge pull request #1161 from NagariaHussain/depr-set-default-site
...
chore: Remove `set-default-site` command
2021-04-27 11:59:32 +05:30
Gavin D'souza
ed3f2d28fb
fix: Remove set-default-site from CLI
2021-04-26 20:16:16 +05:30
Hussain Nagaria
324b58622c
chore: Remove set-default-site command
2021-04-26 17:06:30 +05:30
gavin
c183c90090
Merge pull request #1160 from gavindsouza/yarn-not-found
...
Revert "fix: Use execve and set envvars instead of execv"
2021-04-26 11:54:18 +05:30
Gavin D'souza
64fbeee1e6
Revert "fix: Use execve and set envvars instead of execv"
...
This reverts commit 530a980ef7
.
2021-04-26 11:32:20 +05:30
gavin
085baf5043
Merge pull request #1158 from gavindsouza/ci-updates
...
ci: Dropping tests for < PY3.7
2021-04-23 19:38:59 +05:30
gavin
b72e896e66
Merge branch 'develop' into ci-updates
2021-04-23 19:15:46 +05:30
Gavin D'souza
7e1db3fd74
test: Update env test
...
Env folder's include may be empty or non existent
2021-04-23 19:14:30 +05:30
Gavin D'souza
530a980ef7
fix: Use execve and set envvars instead of execv
...
Changed from execv to execve with empty env dict because bench commands on macOS 10.14.6 PY3.9.0a4 fails with "Error while finding module specification for 'frappe.utils.bench_helper' (ModuleNotFoundError: No module named 'frappe')"
This error has come up in the past too. I'm now suspecting it has
something to do with the current process passing on it's environment
variables to the process that's going to replace it, which causes these
issues.
Note that direct execution of the commands without the bench wrapper
worked fine although via bench failed with the specified error
2021-04-23 18:38:27 +05:30
Gavin D'souza
b0ccb6efbe
fix: Invoke pip via python
...
Due to "WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip. Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue. To avoid this problem you can invoke Python with '-m pip' instead of running pip directly."
2021-04-23 18:37:03 +05:30
gavin
c88e205069
Merge pull request #1159 from revant/docs-docker-readme
...
docs: add docker repo link in README
2021-04-23 15:00:10 +05:30
Revant Nandgaonkar
75632a7616
docs: add docker repo link in README
...
remove docker installation details
refer official link for installation details
2021-04-23 14:54:51 +05:30
Gavin D'souza
89bc45e2d0
ci: Run all builds on 3.7, 3.8, 3.9
...
* Drop CI testing for older versions: 2.7, 3.5, 3.6
2021-04-23 12:22:17 +05:30
gavin
0480b898ae
Merge pull request #1157 from gavindsouza/b-update-breaking-patch
...
fix: Misc fixes
2021-04-23 12:21:08 +05:30
Gavin D'souza
405f41e434
test: Use frappe_theme to test apps instead of erpnext
...
* Don't skip assets
2021-04-23 11:25:29 +05:30
Gavin D'souza
f04a9e6e0d
chore: Remove deprecated command switch-to-master
2021-04-23 11:25:24 +05:30
Gavin D'souza
da85e0ccdd
refactor: Optimize and simplify imports
...
* make relative imports absolute
* minor: Simplify logic
2021-04-23 11:05:06 +05:30