2
0
mirror of https://github.com/frappe/bench.git synced 2024-09-28 14:59:02 +00:00
Commit Graph

2338 Commits

Author SHA1 Message Date
Gavin D'souza
7f4f1b9dc6 ci: Remove needs cond for tests job 2022-08-01 16:33:39 +05:30
Gavin D'souza
73719a26e2 test(init): Run exec_cmd without raise [bug] 2022-08-01 16:33:33 +05:30
Gavin D'souza
b4a6f7fea8 test(app_states): Set git committer info in config 2022-08-01 15:40:54 +05:30
Gavin D'souza
137c786f5e ci: Add Bench linters action 2022-08-01 15:22:48 +05:30
Gavin D'souza
c9c6bf4512 fix: Use hardcoded python3 env cmd for Bench.python 2022-08-01 15:16:03 +05:30
Gavin D'souza
e7c0c264d9 ci: Migrate tests from Travis to GHA 2022-08-01 15:15:48 +05:30
Gavin D'souza
1a062263cf ci: Bump to mariadb 10.6 2022-08-01 14:15:23 +05:30
Gavin D'souza
3b173f92c8 ci: Use Ubuntu focal for tests 2022-08-01 14:04:07 +05:30
Gavin D'souza
e5fa4df5f9 fix: Fetch env python if exists before returning fallback 2022-08-01 11:49:15 +05:30
gavin
0cd5fca322
fix: Remove backup command (#1345)
bench's backup command is redundant and acts as a wrapper over Frappe's
backup command. This caused a conflict with Frappe's CLI after the
resolution correction introduced via a6f196440a

ref: https://github.com/frappe/frappe/runs/7592331617
2022-07-31 22:28:32 +05:30
gavin
1ec17e40f3
Merge pull request #1344 from gavindsouza/dummy-release-trigger-2
fix: Use subscript instead of method for regex
2022-07-30 01:23:11 +05:30
Gavin D'souza
e126ff2439 fix: Use subscript instead of method for regex
This is another dumb attempt to trigger a release because it doesn't get
triggered without PRs linked or even if they're refactors!
2022-07-30 01:20:24 +05:30
gavin
66d41e5c3d
Merge pull request #1343 from frappe/dummy-release-trigger
refactor: Use Suppress instead of try-pass
2022-07-30 01:13:32 +05:30
Gavin D'souza
a5b7a101d2 refactor: Use Suppress instead of try-pass 2022-07-30 01:12:27 +05:30
Gavin D'souza
147aab1e4e chore: Remove dead MANIFEST.in 2022-07-30 01:06:41 +05:30
Gavin D'souza
a0a8133032 build: Include for wheel target 2022-07-30 01:03:20 +05:30
Gavin D'souza
8736a2f3cf docs: Update PY37 shield 2022-07-29 19:44:02 +05:30
Gavin D'souza
060e6b7cea ci: Use hatch to build package 2022-07-29 19:23:39 +05:30
gavin
af05b4945a
Merge pull request #1341 from frappe/gavindsouza-readme-dark
chore: Add logo for Dark mode
2022-07-29 00:18:21 +05:30
gavin
f68ff595bf chore: Add logo for Dark mode 2022-07-29 00:11:34 +05:30
gavin
c71ba2b27c
Merge pull request #1339 from alyf-de/python-venv
fix: use specified python for venv
2022-07-28 21:54:20 +05:30
barredterra
df84c2772d fix: use specified python for venv 2022-07-28 14:19:09 +02:00
gavin
60569ba897
Merge pull request #1337 from gavindsouza/ci-fixes-2022-001
build: pyproject.toml > setup.py + requirements.txt
2022-07-28 14:18:03 +05:30
Gavin D'souza
203f41e405 test: Skip deps resolution for non develop branches 2022-07-28 13:35:04 +05:30
Gavin D'souza
22294fce5b ci: Add PY3.10 to runner matrix
Reduce existing runners based on lesser variance to breakages
2022-07-28 11:50:10 +05:30
Gavin D'souza
5515b0f4ca ci: Update pip, wheel, setuptools explicitly in install 2022-07-28 11:37:16 +05:30
Gavin D'souza
38fa45607d build: Bump python-crontab dependency
Package v2.4.2 leads to a build error on PY 3.7, 3.8

ref: https://app.travis-ci.com/github/frappe/bench/jobs/577932789
2022-07-28 11:24:29 +05:30
Gavin D'souza
86c3c90fd9 build: Retire setup.py + reqs.txt to use pyproject.toml 2022-07-27 18:40:17 +05:30
Gavin D'souza
1badfa8da4 ci: Update conditions for FRAPPE_BRANCH 2022-07-27 16:54:46 +05:30
gavin
e66fe9ca02
Merge pull request #1333 from lhjt/patch-1
fix(nginx): set `proxy_http_version` to `1.1`
2022-07-27 15:34:37 +05:30
Orsiris de Jong
94a25d3da7
fix(config): Fix fail2ban filter (#1308)
* Add missing nginx-proxy filter

* Add all nginx log files to fail2ban filter, regardless of frappe site

* Adds per site nginx logs in /var/log
2022-07-27 14:58:53 +05:30
gavin
1e0054bc14
Merge pull request #1335 from gavindsouza/pre-commit-files
feat!: Add auto-formatting & linting via pre-commit
2022-07-27 14:45:58 +05:30
Gavin D'souza
af46fedc28 refactor(minor): Use more readable alternatives 2022-07-27 14:39:32 +05:30
Gavin D'souza
a84239d6ab refactor: Bench
* Drop patches of v3 & v4
* Re-write buggy / broken code wrt hints by pre-commit checks
* Auto-format and transform code
* Remove re-written & mutable function defaults
2022-07-27 14:39:22 +05:30
Gavin D'souza
b1b8d70055 feat: Add pre-commit checks
* Base pre-commit checks for trailing whitespces, valid files, etc
* pyupgrade with PY37+ syntax
* Aditya's black fork for codebases with tabs
* Flake8 with Frappe's config
2022-07-27 14:38:17 +05:30
gavin
a481934d53
Merge pull request #1334 from gavindsouza/better-cli-resolution
refactor(cli): Commands Resolution
2022-07-27 14:37:16 +05:30
gavin
41b9deb66a
Merge pull request #1336 from gavindsouza/reinstall-app-fix
fix: get-app on existing apps
2022-07-27 14:34:45 +05:30
Gavin D'souza
e03f597ac6 fix: get-app on existing apps
get-app to replace existing folder would fail due to bad url generation.

Changes
* Archive old repo instead of overwritting
* Resetting flags in App instance
2022-07-27 14:24:10 +05:30
Gavin D'souza
8a0b78451b fix: Add support for options on bench main group
Options like --use-feature, --version are tested and support maintained
by the changes defined in this commit
2022-07-27 14:23:16 +05:30
Gavin D'souza
a6f196440a refactor(cli): Commands Resolution
The implementations so far were hacks that worked for the most used
commands but broken down when challenged or expected to maintain
documented usages [eg: custom app commands].

The current implementation consists of a two step approach:
1. figure out command name that user is trying to execute
2. pass the directive to the app (bench, frappe or other) that consists of the cmd

---

For tackling #1, get_cmd_from_sysargv contains exhaustive rules that
cover all (that i know and ive come across) combinations of valid
frappe commands.

For problem #2, a simple check in click's Group object does the trick.

Tested with possible known commands with combinations of context flags
and params, with bench, frappe & external app's commands
2022-07-27 11:08:19 +05:30
Jared L
7da62f96f2
fix(nginx): set proxy_http_version to 1.1
This sets the `proxy_http_version` to `1.1`.

The reason this change should be implemented is that when this is deployed in a Kubernetes environment with Istio, the proxy request fails with HTTP error 426 as the HTTP version is too low for envoy to handle. Setting it to `1.1` will solve the issue.
2022-07-25 10:38:47 +10:00
Gavin D'souza
beac865153 fix: Use == to define had pinned requirement
This allows one to add a dependency like `PyPika = '5.1.0'` directly
instead of `PyPika = '==5.1.0'`
2022-06-29 19:29:31 +05:30
Aradhya Tripathi
45267fc897
fix: fixed update_app_states call (#1326) 2022-06-23 00:10:41 +05:30
gavin
28549ff139
Merge pull request #1323 from gavindsouza/dev-deps-toml
feat: Dev Dependencies via pyproject.toml
2022-06-17 18:02:22 +05:30
Gavin D'souza
75957a56ee feat: Setup dev-dependencies defined via pyproject
Since support for pyproject.toml exists, Frappe has gotten rid of
requirements.txt file. However, dev-requirements.txt file still existed
in Frappe & other apps. With this, we can get rid of the separate
dev-reqs file as well and replace it by defining the deps in pyproject
under [tool.bench.dev-dependencies]

Example:

For Frappe, this transition will look like moving the contents of
dev-requirements.txt as follows:

```
\# dev-requirements.txt
coverage==5.5
Faker~=13.12.1
pyngrok~=5.0.5
unittest-xml-reporting~=3.0.4

```

```
\# pyproject.toml
[tool.bench.dev-dependencies]
coverage = "==5.5"
Faker = "~=13.12.1"
pyngrok = "~=5.0.5"
unittest-xml-reporting = "~=3.0.4"
```

Note: If dev-dependencies are defined in pyproject.toml, and a
dev-dependencies.txt file exists - the txt file will be ignored.
2022-06-16 18:16:57 +05:30
Gavin D'souza
ffae670be7 fix: (re)Install every Frappe app even if not installed to env 2022-06-16 17:54:21 +05:30
gavin
39553b343b
Merge pull request #1322 from gavindsouza/pyproject-toml
feat: Support Frappe app distributions with pyproject.toml
2022-06-14 17:44:39 +05:30
Gavin D'souza
800394cdda feat: Support Frappe app distributions with pyproject.toml
Patches get_app_name which reads app name from pyproject's project.name
attribute, setup.cfg's metadata.name or setup.py's name variable.
2022-06-14 16:01:42 +05:30
Gavin D'souza
24e2dd37fe chore: Remove release related tests 2022-06-14 16:00:50 +05:30
Gavin D'souza
21eceae6ac chore: Drop dead code
tx [vulture](https://pypi.org/project/vulture/)
2022-06-14 15:48:56 +05:30