From dad0729aaecc487d1f58c552c811a3675d35ec56 Mon Sep 17 00:00:00 2001
From: akshayitzme <akshaypooloth1@gmail.com>
Date: Sat, 19 Aug 2023 10:33:04 +0530
Subject: [PATCH] fix: moved _validateHasReturnDocs to validations

---
 models/inventory/StockTransfer.ts | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/models/inventory/StockTransfer.ts b/models/inventory/StockTransfer.ts
index 3deb8b86..bcc97fad 100644
--- a/models/inventory/StockTransfer.ts
+++ b/models/inventory/StockTransfer.ts
@@ -198,6 +198,7 @@ export abstract class StockTransfer extends Transfer {
     await validateBatch(this);
     await validateSerialNumber(this);
     await validateSerialNumberStatus(this);
+    await this._validateHasReturnDocs();
   }
 
   async afterSubmit() {
@@ -207,11 +208,6 @@ export abstract class StockTransfer extends Transfer {
     await this._updateItemsReturned();
   }
 
-  async beforeCancel(): Promise<void> {
-    await super.beforeCancel();
-    await this._validateHasReturnDocs();
-  }
-
   async afterCancel(): Promise<void> {
     await super.afterCancel();
     await updateSerialNumbers(this, true, this.isReturn);
@@ -293,7 +289,7 @@ export abstract class StockTransfer extends Transfer {
   }
 
   async _validateHasReturnDocs() {
-    if (!this.name) {
+    if (!this.name || !this.isCancelled) {
       return;
     }