From 561a43cf73b9d1571bcaa760073c0e7a449d4185 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Thu, 12 Jul 2018 20:45:52 +0530
Subject: [PATCH 1/3] Show search only if a route has list

---
 ui/components/Desk.vue | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/ui/components/Desk.vue b/ui/components/Desk.vue
index f191205c..219d8ed1 100644
--- a/ui/components/Desk.vue
+++ b/ui/components/Desk.vue
@@ -2,7 +2,7 @@
     <div class="frappe-desk row no-gutters">
         <frappe-sidebar :sidebarConfig="sidebarConfig"></frappe-sidebar>
         <frappe-main>
-          <frappe-navbar></frappe-navbar>
+          <frappe-navbar :showSearch="showSearch"></frappe-navbar>
           <slot></slot>
         </frappe-main>
     </div>
@@ -18,6 +18,11 @@ export default {
     FrappeSidebar: Sidebar,
     FrappeMain: Main,
     FrappeNavbar: Navbar
+  },
+  computed: {
+    showSearch() {
+      return /list|edit/.test(this.$route.path)
+    }
   }
 };
 </script>

From 8bff2e42fbaab2dcd1d56bd26644be69d6812a18 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Thu, 12 Jul 2018 20:47:46 +0530
Subject: [PATCH 2/3] Filter list based on search value

---
 ui/components/List/List.vue | 14 +++++++++++---
 ui/components/Navbar.vue    | 35 ++++++++++++++++++++++++++++++-----
 ui/pages/ListAndForm.vue    |  4 ++--
 3 files changed, 43 insertions(+), 10 deletions(-)

diff --git a/ui/components/List/List.vue b/ui/components/List/List.vue
index 5e4386d8..7a0acf7e 100644
--- a/ui/components/List/List.vue
+++ b/ui/components/List/List.vue
@@ -29,7 +29,7 @@ import ListItem from './ListItem';
 
 export default {
   name: 'List',
-  props: ['doctype', 'filters'],
+  props: ['doctype'],
   components: {
     ListActions,
     ListItem
@@ -53,6 +53,8 @@ export default {
     frappe.db.on(`change:${this.doctype}`, () => {
       this.updateList();
     });
+    this.$root.$on('search', this.updateList)
+    this.$root.$emit('newList')
   },
   mounted() {
     this.updateList();
@@ -62,7 +64,13 @@ export default {
       let doc = await frappe.getNewDoc(this.doctype);
       this.$router.push(`/edit/${this.doctype}/${doc.name}`);
     },
-    async updateList() {
+    async updateList(query=null) {
+      let filters = null
+      if (query) {
+        filters = {
+          keywords : ['like', query]
+        }
+      }
       const indicatorField = this.hasIndicator ? this.meta.indicators.key : null;
       const fields = [
         'name',
@@ -74,7 +82,7 @@ export default {
       const data = await frappe.db.getAll({
         doctype: this.doctype,
         fields,
-        filters: this.filters || null
+        filters: filters || null
       });
 
       this.data = data;
diff --git a/ui/components/Navbar.vue b/ui/components/Navbar.vue
index fcf8f81a..bc007bd1 100644
--- a/ui/components/Navbar.vue
+++ b/ui/components/Navbar.vue
@@ -1,7 +1,32 @@
 <template>
-    <nav class="frappe-navbar navbar navbar-light bg-light row no-gutters border-bottom border-top">
-        <form class="form-inline col-4 pr-3">
-            <input type="search" name="search" class="form-control shadow-none w-100" placeholder="Search...">
-        </form>
-    </nav>
+	<nav class="frappe-navbar navbar navbar-light bg-light row no-gutters border-bottom border-top">
+		<form v-if="showSearch" class="form-inline col-4 pr-3">
+			<input type="text"
+				v-model="searchValue"
+				@input="updateSearch"
+				name="search"
+				class="form-control shadow-none w-100"
+				placeholder="Search...">
+		</form>
+		<div class="navbar-text">HI</div>
+	</nav>
 </template>
+<script>
+import { debounce } from 'lodash';
+export default {
+    props: ["showSearch"],
+    data() {
+        return {
+            searchValue: ''
+        };
+    },
+    mounted() {
+        this.$root.$on('newList', () => this.searchValue = '')
+    },
+    methods: {
+        updateSearch: debounce(function() {
+            this.$root.$emit("search", this.searchValue);
+        }, 500)
+    }
+};
+</script>
diff --git a/ui/pages/ListAndForm.vue b/ui/pages/ListAndForm.vue
index e867c1c2..52b36495 100644
--- a/ui/pages/ListAndForm.vue
+++ b/ui/pages/ListAndForm.vue
@@ -1,7 +1,7 @@
 <template>
     <div class="frappe-list-form row no-gutters">
         <div class="col-4 border-right">
-            <frappe-list :doctype="doctype" :filters="filters" :key="doctype" />
+            <frappe-list :doctype="doctype" :key="doctype" />
         </div>
         <div class="col-8">
             <frappe-form v-if="name" :key="doctype + name" :doctype="doctype" :name="name" @save="onSave" />
@@ -13,7 +13,7 @@ import List from '../components/List/List';
 import Form from '../components/Form/Form';
 
 export default {
-    props: ['doctype', 'name', 'filters'],
+    props: ['doctype', 'name'],
     components: {
         FrappeList: List,
         FrappeForm: Form

From 5d60955856fe50c39e2eb20f43c386cefe0d7a7e Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Thu, 12 Jul 2018 21:57:23 +0530
Subject: [PATCH 3/3] Refactor code

---
 ui/components/Desk.vue      |  7 +------
 ui/components/List/List.vue |  4 ++--
 ui/components/Navbar.vue    | 37 ++++++++++++++++++++++---------------
 3 files changed, 25 insertions(+), 23 deletions(-)

diff --git a/ui/components/Desk.vue b/ui/components/Desk.vue
index 219d8ed1..1af3221c 100644
--- a/ui/components/Desk.vue
+++ b/ui/components/Desk.vue
@@ -2,7 +2,7 @@
     <div class="frappe-desk row no-gutters">
         <frappe-sidebar :sidebarConfig="sidebarConfig"></frappe-sidebar>
         <frappe-main>
-          <frappe-navbar :showSearch="showSearch"></frappe-navbar>
+          <frappe-navbar></frappe-navbar>
           <slot></slot>
         </frappe-main>
     </div>
@@ -19,11 +19,6 @@ export default {
     FrappeMain: Main,
     FrappeNavbar: Navbar
   },
-  computed: {
-    showSearch() {
-      return /list|edit/.test(this.$route.path)
-    }
-  }
 };
 </script>
 <style>
diff --git a/ui/components/List/List.vue b/ui/components/List/List.vue
index 7a0acf7e..f3676a94 100644
--- a/ui/components/List/List.vue
+++ b/ui/components/List/List.vue
@@ -53,8 +53,8 @@ export default {
     frappe.db.on(`change:${this.doctype}`, () => {
       this.updateList();
     });
-    this.$root.$on('search', this.updateList)
-    this.$root.$emit('newList')
+    this.$root.$on('navbarSearch', this.updateList);
+    this.$root.$emit('newList');
   },
   mounted() {
     this.updateList();
diff --git a/ui/components/Navbar.vue b/ui/components/Navbar.vue
index bc007bd1..3e0f1a9e 100644
--- a/ui/components/Navbar.vue
+++ b/ui/components/Navbar.vue
@@ -6,27 +6,34 @@
 				@input="updateSearch"
 				name="search"
 				class="form-control shadow-none w-100"
-				placeholder="Search...">
+				:placeholder="_('Search...')">
 		</form>
-		<div class="navbar-text">HI</div>
+		<div class="navbar-text">.</div>
 	</nav>
 </template>
 <script>
 import { debounce } from 'lodash';
 export default {
-    props: ["showSearch"],
-    data() {
-        return {
-            searchValue: ''
-        };
-    },
-    mounted() {
-        this.$root.$on('newList', () => this.searchValue = '')
-    },
-    methods: {
-        updateSearch: debounce(function() {
-            this.$root.$emit("search", this.searchValue);
-        }, 500)
+  props: ['showSearch'],
+  data() {
+    return {
+        searchValue: ''
+    };
+  },
+  computed: {
+    showSearch() {
+      // TODO: Make this configurable
+      return /list|edit/.test(this.$route.path)
     }
+  },
+  mounted() {
+    this.$root.$on('newList', () => this.searchValue = '')
+  },
+  methods: {
+    updateSearch: debounce(function() {
+      this.$root.$emit('navbarSearch', this.searchValue)
+    }, 500)
+  }
 };
 </script>
+