From eeb2eab3e5bfdf97c8093be03294358c364ef341 Mon Sep 17 00:00:00 2001 From: 18alantom <2.alan.tom@gmail.com> Date: Wed, 28 Jun 2023 10:25:39 +0530 Subject: [PATCH] fix: skip telemetry log for auto entries --- fyo/telemetry/telemetry.ts | 12 +++++++++++- fyo/telemetry/types.ts | 1 + src/utils/printTemplates.ts | 3 +++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/fyo/telemetry/telemetry.ts b/fyo/telemetry/telemetry.ts index 4ddf6371..3b7358b0 100644 --- a/fyo/telemetry/telemetry.ts +++ b/fyo/telemetry/telemetry.ts @@ -1,5 +1,6 @@ import { Fyo } from 'fyo'; import { Noun, Telemetry, Verb } from './types'; +import { ModelNameEnum } from 'models/types'; /** * # Telemetry @@ -26,6 +27,11 @@ import { Noun, Telemetry, Verb } from './types'; * the app is hidden. */ +const ignoreList: string[] = [ + ModelNameEnum.AccountingLedgerEntry, + ModelNameEnum.StockLedgerEntry, +]; + export class TelemetryManager { #url = ''; #token = ''; @@ -80,7 +86,11 @@ export class TelemetryManager { } #sendBeacon(verb: Verb, noun: Noun, more?: Record) { - if (!this.hasCreds || this.fyo.store.skipTelemetryLogging) { + if ( + !this.hasCreds || + this.fyo.store.skipTelemetryLogging || + ignoreList.includes(noun) + ) { return; } diff --git a/fyo/telemetry/types.ts b/fyo/telemetry/types.ts index 351cd634..c9c85df0 100644 --- a/fyo/telemetry/types.ts +++ b/fyo/telemetry/types.ts @@ -9,6 +9,7 @@ export enum Verb { Cancelled = 'cancelled', Imported = 'imported', Exported = 'exported', + Printed = 'printed', Closed = 'closed', Opened = 'opened', Resumed = 'resumed', diff --git a/src/utils/printTemplates.ts b/src/utils/printTemplates.ts index 08d9d049..f59bce6e 100644 --- a/src/utils/printTemplates.ts +++ b/src/utils/printTemplates.ts @@ -290,6 +290,8 @@ export async function updatePrintTemplates(fyo: Fyo) { updateList.push(...updates); } + const isLogging = fyo.store.skipTelemetryLogging; + fyo.store.skipTelemetryLogging = true; for (const { name, type, template } of updateList) { const doc = await getDocFromNameIfExistsElseNew( ModelNameEnum.PrintTemplate, @@ -299,6 +301,7 @@ export async function updatePrintTemplates(fyo: Fyo) { await doc.set({ name, type, template, isCustom: false }); await doc.sync(); } + fyo.store.skipTelemetryLogging = isLogging; } function getPrintTemplateUpdateList(