18alantom
c38bbcba98
fix: add missing dq
2024-03-07 12:54:09 +05:30
Alan
6cf8f4ecae
Merge pull request #24317 from blaggacao/chore/cleanup-esbuild-path-resolution
...
chore: remove confusing indirections from esbuild path resolution
2024-02-27 11:09:37 +05:30
18alantom
c07c86e4fc
fix: install deps if node_modules not found
2024-02-21 10:45:16 +05:30
David Arnold
cad020e08c
Merge remote-tracking branch 'origin/develop' into chore/cleanup-esbuild-path-resolution
2024-01-31 21:05:43 +01:00
18alantom
60fb4f6d22
fix(Build): reinit app_path, avoid get_app_path
...
frappe/esbuild seems like a ticking timebomb, I have
not seen so many global variables since 2nd year of
engineering.
The function get_app_path just returns a value from an
object that is initialized when the file is imported. Why
is it a function in the first place. What lawless idiocy
is this?
2024-01-19 15:20:30 +05:30
Ankush Menat
2b3ab02d79
Merge branch 'develop' into add-using-cached-build-flag
2024-01-18 10:51:04 +05:30
18alantom
9ece71bc56
feat: add using-cached flag to bench build
...
- add using-cache flag to node esbuild call
The flag is to be used by bench get-app if its is
using cache.
Flag causes building of assets to not run and
instead updates assets.json files from built assets.
Linking of assets in the sites folder also occurs.
2024-01-17 13:20:57 +05:30
David Arnold
93bbe615ba
chore: use env variables in esbuilds
2024-01-15 11:17:29 +01:00
David Arnold
3542c22365
chore: remove confusing indirections from esbuild path resolution
2024-01-14 12:28:25 +01:00
David Arnold
68d586e206
feat: import scss from node_modules in apps also ( #22519 )
...
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-30 19:01:47 +05:30
Suraj Shetty
dff950a56d
fix: Remove unused resolve
in code
...
fixes: https://github.com/frappe/frappe/actions/runs/5655856445/job/15321775151?pr=21782
2023-07-25 18:20:00 +05:30
David Arnold
7780670ae4
build(deps): update node redis client to v4 ( #21797 )
...
* build(deps): update redis client to v4 in legacy mode
* fix: node17+ - prefer ipv4
* chore: use redis client v4 api (async) and adapt error handling
* fix: timeout by exiting if not in watch mode
* fix: parse message before republishing
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-25 14:07:46 +05:30
Ankush Menat
b5409f6f07
chore: remove eslint-disable*
2023-07-14 15:41:20 +05:30
Suraj Shetty
fe25fe1db1
feat: A flag (--save-metafiles) to save esbuild metafiles
...
- Useful for analysing bundle size
2023-06-26 09:14:17 +05:30
Aditya Hase
5b52350ae0
fix(build): Exit build process instead of throwing an exception
2023-06-16 12:27:30 +05:30
Ankush Menat
3414c0d063
refactor!: Merge redis_socketio and redis_queue
...
- realtime communication uses pub-sub and no storage. So using same
redis server for both should be just fine.
- This is how FC works since quite a lot of time. We haven't seen any
problem so far.
2023-06-11 11:40:22 +05:30
Aditya Hase
22e3ec8bf4
fix(build): Propogate exit code from yarn build to bench build ( #21084 )
...
When `yarn build` fails `bench build` ignores the error and exits with exit code 0
2023-05-23 15:47:13 +05:30
Mohammad Hussain Nagaria
55867282ad
fix: also build jsx files ( #20624 )
2023-04-10 09:57:34 +05:30
Ankush Menat
17e546f1a5
Revert "fix: allow backtick in HTML templates as well"
...
This reverts commit 2f96458bcb
.
2022-10-12 18:50:12 +05:30
Shariq Ansari
3504ca08f2
fix: revert dynamic entryNames for js
2022-10-11 14:26:32 +05:30
Sagar Vora
2f96458bcb
fix: allow backtick in HTML templates as well
2022-10-11 13:22:13 +05:30
Shariq Ansari
bfbdaa4f4d
chore: code cleanup
...
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-10-11 12:32:36 +05:30
Shariq Ansari
9a22ab0d6a
fix: remove .css & .css.map file
2022-10-10 21:38:05 +05:30
Shariq Ansari
09f9cda115
fix: load css data instead of loading css bundle file when js is loaded
2022-10-10 21:01:28 +05:30
Shariq Ansari
fdc1bbb23d
fix: create directory recursively
2022-10-07 20:49:54 +05:30
Shariq Ansari
0b95de37fd
chore: minor fix
2022-10-05 16:37:36 +05:30
Shariq Ansari
2b549619a8
fix: handle loading of bundle css & js in website
2022-10-03 13:54:48 +05:30
Shariq Ansari
2c9a447f83
chore: linter fixes
2022-09-28 15:30:59 +05:30
Shariq Ansari
44e9f6b9ab
build(deps): Bump from vue 2 to vue 3
2022-09-28 14:55:07 +05:30
Ankush Menat
1ba99396bc
fix: fail code when build fails in production
...
In production it is useful to fail with proper exit code. To avoid
silently pushing bad assets in built pipelines.
2022-09-14 19:40:22 +05:30
Ankush Menat
0a6433bf5d
fix(DX): reduce retry count for esbuild-redis
...
closes https://github.com/frappe/frappe/issues/17976
2022-09-04 11:30:03 +05:30
Ankush Menat
40f27f908a
style: format JS files with prettier
2022-08-04 14:51:01 +05:30
Gavin D'souza
ef234da171
fix: Don't retry asset caching in CI or developer_mode
2022-07-28 15:40:13 +05:30
Suraj Shetty
eeeef86ae3
fix: Replace node-sass with dart-sass
2022-06-24 19:11:44 +05:30
Faris Ansari
93169e054d
chore: set esbuild output target to es2017
2022-04-01 21:30:42 +05:30
Rushabh Mehta
0b8a2edee7
fix(build): separate assets.json and assets-rtl.json to fix concurrency issue
2022-03-17 14:54:17 +05:30
Suraj Shetty
ccb4475411
build: Pass watchFiles list to auto trigger rebuild process on template change
2022-03-15 09:29:54 +05:30
Suraj Shetty
24f3123552
build: Use @frappe/esbuild-plugin-postcss2 to auto-trigger rebuild on scss file changes
2022-03-15 09:28:30 +05:30
Pruthvi Patel
30452c8b9c
style: use const
instead of let
2021-11-09 13:00:15 +05:30
Pruthvi Patel
c648346742
refactor: a better way to cleanup older assets when newer ones are built
2021-11-09 12:54:17 +05:30
Faris Ansari
179960d67f
Merge pull request #14134 from netchampfaris/print-format-builder-beta
...
feat: New Print Format Builder
2021-10-25 12:12:08 +05:30
Sagar Vora
28fce91673
fix: consistent description for Live Reload ( #14554 )
2021-10-24 13:50:07 +05:30
Faris Ansari
5345d4ce7b
Merge branch 'develop' of https://github.com/frappe/frappe into print-format-builder-beta
2021-10-20 18:40:18 +05:30
gavin
fbe925b42c
Merge pull request #14238 from resilient-tech/autoreload_on_build
...
feat: automatically reload web pages whenever JS/CSS assets are rebuilt
2021-10-19 14:13:04 +05:30
Pruthvi Patel
3cec476cbc
fix: add whitespace
2021-10-18 19:07:13 +05:30
Pruthvi Patel
d99403393a
fix: rename auto-reload
to live-reload
2021-10-18 17:52:33 +05:30
Ankush Menat
e6bbc698d0
ci: fail CI if asset bundling fails ( #14364 )
...
* ci: fail CI if asset bundling fails
* chore: formatting
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-10-08 11:40:31 +05:30
Sagar Vora
01d69b67c7
feat: automatically reload web pages whenever JS/CSS assets are rebuilt
2021-09-17 12:33:36 +05:30
Faris Ansari
f58254db78
fix: poor man's hot reload
2021-09-06 16:57:14 +05:30
Suraj Shetty
70e4b8a459
fix: Use different key for RTL assets
2021-07-05 14:39:46 +05:30