From 53c6a0e0c6778c018e7d76081750d75a4a923a4e Mon Sep 17 00:00:00 2001
From: Kevin Wakhisi Maraka <kevinwakhisi70@gmail.com>
Date: Fri, 16 Feb 2024 09:53:01 +0300
Subject: [PATCH] chore! :alien: Enhance dev container YAML (#1332)

* chore!i :alien: Enhance dev container YAML

Enhance dev container YAML to meet standards and integrate personal
GitHub environment token
Refactored the existing dev container YAML configuration to adhere to
best practices and coding standards. This includes optimizing container
setup and dependencies for smoother development workflows. Additionally,
integrated a personal GitHub environment token for secure authentication
and access to GitHub resources within the container environment. This
improvement enhances both security and usability, streamlining the
development process.

* chore :lipstick: Fixed earlier commit

Earlier commit fixed using pre-commit
---
 devcontainer-example/devcontainer.json | 38 ++++++++++++++++----------
 1 file changed, 23 insertions(+), 15 deletions(-)

diff --git a/devcontainer-example/devcontainer.json b/devcontainer-example/devcontainer.json
index d80b845d..dd918069 100644
--- a/devcontainer-example/devcontainer.json
+++ b/devcontainer-example/devcontainer.json
@@ -2,24 +2,32 @@
   "name": "Frappe Bench",
   "forwardPorts": [8000, 9000, 6787],
   "remoteUser": "frappe",
-  "settings": {
-    "terminal.integrated.profiles.linux": {
-      "frappe bash": {
-        "path": "/bin/bash",
-      },
-    },
-    "terminal.integrated.defaultProfile.linux": "frappe bash",
-    "debug.node.autoAttach": "disabled",
+  "customizations": {
+    "vscode": {
+      "extensions": [
+        "ms-python.python",
+        "ms-vscode.live-server",
+        "grapecity.gc-excelviewer",
+        "mtxr.sqltools",
+        "visualstudioexptteam.vscodeintellicode"
+      ],
+      "settings": {
+        "terminal.integrated.profiles.linux": {
+          "frappe bash": {
+            "path": "/bin/bash"
+          }
+        },
+        "terminal.integrated.defaultProfile.linux": "frappe bash",
+        "debug.node.autoAttach": "disabled"
+      }
+    }
   },
   "dockerComposeFile": "./docker-compose.yml",
   "service": "frappe",
   "workspaceFolder": "/workspace/development",
   "shutdownAction": "stopCompose",
-  "extensions": [
-    "ms-python.python",
-    "ms-vscode.live-server",
-    "grapecity.gc-excelviewer",
-    "mtxr.sqltools",
-    "visualstudioexptteam.vscodeintellicode",
-  ],
+  "postStartCommand": "sudo service ssh start",
+  "mounts": [
+    "source=${localEnv:HOME}${localEnv:USERPROFILE}/.ssh,target=/home/frappe/.ssh,type=bind,consistency=cached"
+  ]
 }