From 55e4a53d5bb3f299982fc25f9a7f85e883161611 Mon Sep 17 00:00:00 2001 From: Hendy Irawan Date: Sat, 1 Aug 2020 12:26:03 +0700 Subject: [PATCH] refactor: Disable PostgreSQL by default, fixes #317 --- .devcontainer/docker-compose.yml | 15 ++++++++------- development/README.md | 5 ++++- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/.devcontainer/docker-compose.yml b/.devcontainer/docker-compose.yml index 104c5442..c46f21ca 100644 --- a/.devcontainer/docker-compose.yml +++ b/.devcontainer/docker-compose.yml @@ -9,13 +9,14 @@ services: - ../installation/frappe-mariadb.cnf:/etc/mysql/conf.d/frappe.cnf - mariadb-vol:/var/lib/mysql - postgresql: - image: postgres:11.8 - restart: on-failure - environment: - - POSTGRES_PASSWORD=123 - volumes: - - postgresql-vol:/var/lib/postgresql/data + # Enable PostgreSQL only if you use it, see development/README.md for more information. + # postgresql: + # image: postgres:11.8 + # restart: on-failure + # environment: + # - POSTGRES_PASSWORD=123 + # volumes: + # - postgresql-vol:/var/lib/postgresql/data redis-cache: image: redis:alpine diff --git a/development/README.md b/development/README.md index b4e72dce..f7e4bc25 100644 --- a/development/README.md +++ b/development/README.md @@ -24,7 +24,10 @@ cd frappe_docker ## Use VSCode Remote Containers extension -For most people getting started with Frappe development, the best solution is to use [ VSCode Remote - Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers). +For most people getting started with Frappe development, the best solution is to use [VSCode Remote - Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers). + +Before opening the folder in container, determine the database that you want to use. The default is MariaDB. +If you want to use PostgreSQL instead, edit `.devcontainer/docker-compose.yml` and uncomment the section for `postgresql` service, and you may also want to comment `mariadb` as well. VSCode should automatically inquire you to install the required extensions, that can also be installed manually as follows: