From 7ef28a5d5f91a1110c775d6b09bd04a091a14194 Mon Sep 17 00:00:00 2001 From: Hendy Irawan Date: Sun, 9 Aug 2020 02:59:51 +0700 Subject: [PATCH] docs: Clarify requirement of repository naming and branch naming --- docs/custom-apps-for-production.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/custom-apps-for-production.md b/docs/custom-apps-for-production.md index cce67094..0f8a988c 100644 --- a/docs/custom-apps-for-production.md +++ b/docs/custom-apps-for-production.md @@ -20,6 +20,8 @@ RUN install_app [custom] https://github.com/[username]/[custom] [branch] # Only add the branch if you are using a specific tag or branch. ``` +**Note:** Replace `https://github.com/[username]/[custom]` above with your custom app's Git repository URL (may include credentials if needed). Your custom app Git repository **must** be named exactly as the custom app's name, and use the same branch name as Frappe/ERPNext branch name that you use. + Create a `Dockerfile` in `./build/[custom]-nginx` with the following content: ```Dockerfile @@ -27,7 +29,7 @@ FROM bitnami/node:12-prod COPY build/[custom]-nginx/install_app.sh /install_app -RUN /install_app [custom] https://github.com/[username]/[custom] +RUN /install_app [custom] https://github.com/[username]/[custom] [branch] FROM frappe/erpnext-nginx:edge @@ -53,4 +55,4 @@ Open up `./installation/docker-compose-custom.yml` and replace all instances of sed -i "s#\[app\]#[custom]#" ./installation/docker-compose-custom.yml ``` -Install like usual, except that when you set the `INSTALL_APPS` variable to `erpnext,[custom]`. \ No newline at end of file +Install like usual, except that when you set the `INSTALL_APPS` variable to `erpnext,[custom]`.