2
0
mirror of https://github.com/frappe/frappe_docker.git synced 2024-09-18 18:19:02 +00:00
frappe_docker/development
Lev a9b6b755ce
Global refactoring (#617)
* Rename `bench-build` target to `bench` in bake file

* Update bake file and break everything

* Rename docker-compose.yml to compose.yml to avoid conflicting on `docker buildx bake`

* Fix groups in bake file

* Update frappe-worker

* Update frappe-nginx, erpnext-nginx

* Remove old erpnext images

* Update frappe-socketio

* Fix develop frappe-nginx build on linux/arm64

* Update dockerignore

* Update gitignore

* Update gitignore

* Update .env files

* Update installation (overrides)

* Update tests

* Fix image names

* Update compose

* Update get-latest-tags

* Update CI

* Setup and remove .env on tests

* Add build bench workflow

* Add triggers to main workflow

* Add release helm job

* Use reusable workflows

* Rollback

* Print configuration before running tests

* Show tests/.env

* Revert "Show tests/.env"

This reverts commit 4bc3bdebaf.

* Fix ci image versions

* Remove `frappe-` prefix in build directories

* Move requirements-dev.txt

* Fix image name in CI

* Update gitignore

* Update pre-commit config

* Drop `version:` in compose files

* Add push-backup

* Fix postgres CI test

* Change .yml to .yaml in compose file to follow compose-spec

* Remove prettierignore

* Fix dockerignore

* Change .yml to .yaml in compose file to follow compose-spec

* Don't depend on boto3 while testing (do it in backend)

* Update erpnext example version

* Don't fail ping on URLError

* Move assets volume to main compose file

* Fix type annotations for v12

* Fix postgres ci override in tests

* Fix spaces in socketio

* Reorder stages in nginx image, improve perfomance

* Remove unused todo

* Optimize worker build

* Install Node in worker image

* Add 502 error page

* Remove unused quiet-pull in tests

* Add configurator service to dynamically set common config

* Remove unused compose.ci-postgres.yml

* Use Python for configurator service: faster and more robust

* Add TODO.md

* Use python script to get latest tags in CI

* Clean up nginx dockerfile

* Remove VOLUME declaration

https://stackoverflow.com/a/55052682

* Add custom app example

* Remove pwd for now

* Remove pwd for now

* Use jq for parsing config in healthcheck

* Take advantage of yaml lang: add defaults in compose file. Also require env vars

* Fix CI

* Use resusable workflow

* Update

* Move release_helm job to main.yml

* Rename docker-build to docker-build-push

* Rename main to build_stable

* Rename bench targets

* Remove quotes from docker-build-push inputs

* Update build develop

* Remove HELM_DEPLOY_KEY secret from docker-build-push

* Add job names

* Remove build_bench workflow

* Update version input description in docker-build-push

* Print .env in tests, if version is develop, change to latest (for tag)

* Fix env setup

* Uncomment tests

* Parse and set short tags from git tag in bake file

* Move devcontainer settings to devcontainer.json

* Add db command notice

* Fix CI?

* Fix inconsistencies in development readme

* Remove pwd for now

* Remove custom apps for production instruction

* Update todos

* Add docs for images and compose files

* Add variables docs and allow custom frappe site name header

* Add notice about internal environment variables

* Update site-operations docs

* Update todos

* Add Overrides header in images-and-compose-files

* Update todos

* Remove extra docs

* Don't log requests in worker image (nginx already does that)

* Remove default value of FRAPPE_SITE_NAME_HEADER in example.env

* Use file that consistent in v12, v13 and develop to check /assets

* Fix paths in CI

* Update todos

* Remove TODO.md

* Update tests/_check_backup_files.py

Co-authored-by: Revant Nandgaonkar <revant.one@gmail.com>

* Change variables MINIO_ACCESS_KEY and MINIO_SECRET_KEY to S3_ACCESS_KEY, S3_SECRET_KEY in tests

* Fix S3 test

* Use `nginxinc/nginx-unprivileged` instead of `nginx` image

Also use Ngnix 1.20 instead of unstable 1.21

* Fix https override

* Update Dockerfile

* Mount assets to backend service in read only mode

* Touch .build (#307), use scripts from nginx image to generate config and touch .build

* Update example env after building stable images

* Touch `.build` on develop image (untill https://github.com/frappe/frappe/issues/15396 is resolved)

* Add `make` to worker build deps for linux/arm64

* Fix update example.env job

* Fix .build creation on develop branch

* Move bench CI to different file

This way workflow runs only on PRs that relevant to bench build

* Fix app name in custom app example

* Update erpnext and frappe versions in example.env

* Don't install `svg-sprite` and `sass` node modules in nginx image on linux/arm64 (https://github.com/frappe/frappe/pull/15275)

* docs: README and docs

* docs: add link to site operations from docker swarm

* ci: fix tests as per changes to compose.yaml

* docs: move wiki articles to docs

* docs: fix add custom domain

* docs: fix patch code from images

* fix: do not expose port 80 for old images

* fix: custom domain labels to frontend container/service

* Add missing descriptions to envs in example.env

* Fix redis depends_on

* Fix docker compose in tests when not running on TTY

* Set -T flag in `docker compose exec` only if not tty

* Run pre-commit on docs

* Remove postgres healthcheck (it gets overriden by mariadb)

* Refactor test

* Update workflow names

* Add pip to dependabot config

* docs: backup and push (#19)

* Beautify changes by @revant (#20)

* feat: add gevent to worker image

* feat: real_ip configuration for nginx

* Return `healthcheck.sh` just for tests

Co-authored-by: Lev Vereshchagin <mail@vrslev.com>

* Make pretend bench catch unknown commands (closes #666)

* Remove debug print in push-backup

* Fix typing issues in push-backup

* Update file keys in push-backups: from abs path to <site>/<file>

* Refactor push-backup

* Move gevent installation in Frappe step

* Don't pin boto stubs requirement

* Cache pip deps on build

* Update example env versions

* Refactor check backup files

* Fix backup test

* Fix backup test

* Rename build/ dir to images/

* Rename build/ dir to images/

* Fix /build -> /images in docs

* Update example.env

* Use reusable workflow in frappe user instead of vrslev

* Fix compose`s `project` option in docs (https://github.com/frappe/frappe_docker/pull/617#issuecomment-1065178792)

* Add note about project option in site-operations doc

* Update example env

* Rename build arg `USERNAME` to `REGISTRY_USER`

* Allow https proxy to access Docker socket

* Revert "Use reusable workflow in frappe user instead of vrslev"

This reverts commit 6062500d0d.

* Revert "Revert "Use reusable workflow in frappe user instead of vrslev""

This reverts commit 4680d18ff8.

Co-authored-by: Revant Nandgaonkar <revant.one@gmail.com>
2022-03-14 11:23:03 +05:30
..
vscode-example Global refactoring (#617) 2022-03-14 11:23:03 +05:30
README.md Global refactoring (#617) 2022-03-14 11:23:03 +05:30

Getting Started

Prerequisites

In order to start developing you need to satisfy the following prerequisites:

  • Docker
  • docker-compose
  • user added to docker group

It is recommended you allocate at least 4GB of RAM to docker:

Bootstrap Containers for development

Clone and change directory to frappe_docker directory

git clone https://github.com/frappe/frappe_docker.git
cd frappe_docker

Copy example devcontainer config from devcontainer-example to .devcontainer

cp -R devcontainer-example .devcontainer

Copy example vscode config for devcontainer from development/vscode-example to development/.vscode. This will setup basic configuration for debugging.

cp -R development/vscode-example development/.vscode

Use VSCode Remote Containers extension

For most people getting started with Frappe development, the best solution is to use VSCode Remote - Containers extension.

Before opening the folder in container, determine the database that you want to use. The default is MariaDB. If you want to use PostgreSQL instead, edit .devcontainer/docker-compose.yml and uncomment the section for postgresql service, and you may also want to comment mariadb as well.

VSCode should automatically inquire you to install the required extensions, that can also be installed manually as follows:

  • Install Remote - Containers for VSCode
    • through command line code --install-extension ms-vscode-remote.remote-containers
    • clicking on the Install button in the Vistual Studio Marketplace: Remote - Containers
    • View: Extensions command in VSCode (Windows: Ctrl+Shift+X; macOS: Cmd+Shift+X) then search for extension ms-vscode-remote.remote-containers

After the extensions are installed, you can:

  • Open frappe_docker folder in VS Code.
    • code .
  • Launch the command, from Command Palette (Ctrl + Shift + P) Remote-Containers: Reopen in Container. You can also click in the bottom left corner to access the remote container menu.

Notes:

  • The development directory is ignored by git. It is mounted and available inside the container. Create all your benches (installations of bench, the tool that manages frappe) inside this directory.
  • Node v14 and v10 are installed. Check with nvm ls. Node v14 is used by default.

Setup first bench

Run the following commands in the terminal inside the container. You might need to create a new terminal in VSCode.

bench init --skip-redis-config-generation --frappe-branch version-13 frappe-bench
cd frappe-bench

Note: For version 12 use Python 3.7 by passing option to bench init command, e.g. bench init --skip-redis-config-generation --frappe-branch version-12 --python python3.7 frappe-bench

Setup hosts

We need to tell bench to use the right containers instead of localhost. Run the following commands inside the container:

bench set-mariadb-host mariadb
bench set-redis-cache-host redis-cache:6379
bench set-redis-queue-host redis-queue:6379
bench set-redis-socketio-host redis-socketio:6379

Edit Honcho's Procfile

Note : With the option '--skip-redis-config-generation' during bench init, these actions are no more needed. But at least, take a look to ProcFile to see what going on when bench launch honcho on start command

Honcho is the tool used by Bench to manage all the processes Frappe requires. Usually, these all run in localhost, but in this case, we have external containers for Redis. For this reason, we have to stop Honcho from trying to start Redis processes.

Open the Procfile file and remove the three lines containing the configuration from Redis, either by editing manually the file:

code Procfile

Or running the following command:

sed -i '/redis/d' ./Procfile

Create a new site with bench

You can create a new site with the following command:

bench new-site sitename --no-mariadb-socket

sitename MUST end with .localhost for trying deployments locally.

for example:

bench new-site mysite.localhost --no-mariadb-socket

The same command can be run non-interactively as well:

bench new-site mysite.localhost --mariadb-root-password 123 --admin-password admin --no-mariadb-socket

The command will ask the MariaDB root password. The default root password is 123. This will create a new site and a mysite.localhost directory under frappe-bench/sites. The option --no-mariadb-socket will configure site's database credentials to work with docker. You may need to configure your system /etc/hosts if you're on Linux, Mac, or its Windows equivalent.

To setup site with PostgreSQL as database use option --db-type postgres and --db-host postgresql. (Available only v12 onwards, currently NOT available for ERPNext).

Example:

bench new-site mypgsql.localhost --db-type postgres --db-host postgresql

To avoid entering postgresql username and root password, set it in common_site_config.json,

bench config set-common-config -c root_login postgres
bench config set-common-config -c root_password '"123"'

Note: If PostgreSQL is not required, the postgresql service / container can be stopped.

Set bench developer mode on the new site

To develop a new app, the last step will be setting the site into developer mode. Documentation is available at this link.

bench --site mysite.localhost set-config developer_mode 1
bench --site mysite.localhost clear-cache

Install an app

To install an app we need to fetch it from the appropriate git repo, then install in on the appropriate site:

You can check VSCode container remote extension documentation regarding git credential sharing.

To install custom app

# --branch is optional, use it to point to branch on custom app repository
bench get --branch version-12 https://github.com/myusername/myapp
bench --site mysite.localhost install-app myapp

To install ERPNext (from the version-12 branch):

bench get --branch version-12 erpnext
bench --site mysite.localhost install-app erpnext

Note: Both frappe and erpnext must be on branch with same name. e.g. version-12

Start Frappe without debugging

Execute following command from the frappe-bench directory.

bench start

You can now login with user Administrator and the password you choose when creating the site. Your website will now be accessible at location mysite.localhost:8000 Note: To start bench with debugger refer section for debugging.

Start Frappe with Visual Studio Code Python Debugging

To enable Python debugging inside Visual Studio Code, you must first install the ms-python.python extension inside the container. This should have already happened automatically, but depending on your VSCode config, you can force it by:

  • Click on the extension icon inside VSCode
  • Search ms-python.python
  • Click on Install on Dev Container: Frappe Bench
  • Click on 'Reload'

We need to start bench separately through the VSCode debugger. For this reason, instead of running bench start you should run the following command inside the frappe-bench directory:

honcho start \
    socketio \
    watch \
    schedule \
    worker_short \
    worker_long \
    worker_default

Alternatively you can use the VSCode launch configuration "Honcho SocketIO Watch Schedule Worker" which launches the same command as above.

This command starts all processes with the exception of Redis (which is already running in separate container) and the web process. The latter can can finally be started from the debugger tab of VSCode by clicking on the "play" button.

You can now login with user Administrator and the password you choose when creating the site, if you followed this guide's unattended install that password is going to be admin.

To debug workers, skip starting worker with honcho and start it with VSCode debugger.

For advance vscode configuration in the devcontainer, change the config files in development/.vscode.

Developing using the interactive console

You can launch a simple interactive shell console in the terminal with:

bench --site mysite.localhost console

More likely, you may want to launch VSCode interactive console based on Jupyter kernel.

Launch VSCode command palette (cmd+shift+p or ctrl+shift+p), run the command Python: Select interpreter to start Jupyter server and select /workspace/development/frappe-bench/env/bin/python.

The first step is installing and updating the required software. Usually the frappe framework may require an older version of Jupyter, while VSCode likes to move fast, this can cause issues. For this reason we need to run the following command.

/workspace/development/frappe-bench/env/bin/python -m pip install --upgrade jupyter ipykernel ipython

Then, run the command Python: Show Python interactive window from the VSCode command palette.

Replace mysite.localhost with your site and run the following code in a Jupyter cell:

import frappe

frappe.init(site='mysite.localhost', sites_path='/workspace/development/frappe-bench/sites')
frappe.connect()
frappe.local.lang = frappe.db.get_default('lang')
frappe.db.connect()

The first command can take a few seconds to be executed, this is to be expected.

Manually start containers

In case you don't use VSCode, you may start the containers manually with the following command:

Running the containers

docker-compose -f .devcontainer/docker-compose.yml up -d

And enter the interactive shell for the development container with the following command:

docker exec -e "TERM=xterm-256color" -w /workspace/development -it devcontainer_frappe_1 bash