From 0a10453ee9866c45a24aed12c925c534f01a5637 Mon Sep 17 00:00:00 2001 From: Vjacheslav Trushkin Date: Wed, 16 Dec 2020 12:04:21 +0200 Subject: [PATCH] Remove IE10 attributes from SVGs in components --- archive/vue2/src/IconifyIcon.ts | 1 - packages/react/src/icon.ts | 1 - packages/react/tests/icon.test.js | 5 ----- packages/svelte/src/generate-icon.js | 1 - packages/vue/src/IconifyIcon.ts | 1 - packages/vue/tests/icon.test.js | 24 ++++++++++++------------ 6 files changed, 12 insertions(+), 21 deletions(-) diff --git a/archive/vue2/src/IconifyIcon.ts b/archive/vue2/src/IconifyIcon.ts index f28122c..45420ea 100644 --- a/archive/vue2/src/IconifyIcon.ts +++ b/archive/vue2/src/IconifyIcon.ts @@ -78,7 +78,6 @@ const svgDefaults = { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlns:xlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', }; diff --git a/packages/react/src/icon.ts b/packages/react/src/icon.ts index feeed33..0cda79c 100644 --- a/packages/react/src/icon.ts +++ b/packages/react/src/icon.ts @@ -71,7 +71,6 @@ const svgDefaults: IconifySVGProps = { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', 'style': {}, // Include style if it isn't set to add verticalAlign later }; diff --git a/packages/react/tests/icon.test.js b/packages/react/tests/icon.test.js index 02d0652..c8229b8 100644 --- a/packages/react/tests/icon.test.js +++ b/packages/react/tests/icon.test.js @@ -27,7 +27,6 @@ describe('Creating component', () => { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', 'style': {}, 'dangerouslySetInnerHTML': { @@ -52,7 +51,6 @@ describe('Creating component', () => { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', 'style': { verticalAlign: '-0.125em', @@ -80,7 +78,6 @@ describe('Creating component', () => { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', 'style': {}, 'dangerouslySetInnerHTML': { @@ -122,7 +119,6 @@ describe('Creating component', () => { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', 'style': {}, 'dangerouslySetInnerHTML': { @@ -164,7 +160,6 @@ describe('Creating component', () => { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlnsXlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', 'style': {}, 'dangerouslySetInnerHTML': { diff --git a/packages/svelte/src/generate-icon.js b/packages/svelte/src/generate-icon.js index 2d7685b..93a31a6 100644 --- a/packages/svelte/src/generate-icon.js +++ b/packages/svelte/src/generate-icon.js @@ -16,7 +16,6 @@ const svgDefaults = { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlns:xlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', }; diff --git a/packages/vue/src/IconifyIcon.ts b/packages/vue/src/IconifyIcon.ts index 16fa5b9..2dcb2d2 100644 --- a/packages/vue/src/IconifyIcon.ts +++ b/packages/vue/src/IconifyIcon.ts @@ -68,7 +68,6 @@ const svgDefaults = { 'xmlns': 'http://www.w3.org/2000/svg', 'xmlns:xlink': 'http://www.w3.org/1999/xlink', 'aria-hidden': true, - 'focusable': false, 'role': 'img', }; diff --git a/packages/vue/tests/icon.test.js b/packages/vue/tests/icon.test.js index d682525..4a8167a 100644 --- a/packages/vue/tests/icon.test.js +++ b/packages/vue/tests/icon.test.js @@ -38,7 +38,7 @@ describe('Mounting component', () => { const item = wrapper; //.findComponent(Icon); expect(item.exists()).toBe(true); expect(item.html()).toStrictEqual( - '' + '' ); }); }); @@ -59,7 +59,7 @@ describe('Rendering icon', () => { const item = wrapper; //.findComponent(Icon); expect(item.exists()).toBe(true); expect(item.html()).toStrictEqual( - '