agerix/iconify
2
0
Fork 0
mirror of https://github.com/iconify/iconify.git synced 2025-01-22 14:48:24 +00:00
Code Issues Releases Activity

Replace jest done function with promises in utils tests

Browse Source
This commit is contained in:
Vjacheslav Trushkin 2022-09-07 20:00:33 +03:00
parent 33b3e42834
commit 2dc12bd462
3 changed files with 679 additions and 608 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
packages/utils/tests/validate-alias-test.ts
View File

@ -46,7 +46,8 @@ describe('Testing validating alias', () => {
});
});
test('Null', (done) => {
test('Null', () => {
return new Promise((fulfill, reject) => {
try {
validateIconSet({
prefix: 'foo',
@ -57,8 +58,9 @@ describe('Testing validating alias', () => {
},
aliases: null,
});
done('Expected to throw error when aliases is null');
} catch (err) {
reject('Expected to throw error when aliases is null');
return;
} catch {
//
}
@ -85,10 +87,12 @@ describe('Testing validating alias', () => {
},
});
done();
fulfill(true);
});
});
test('Invalid parent', (done) => {
test('Invalid parent', () => {
return new Promise((fulfill, reject) => {
try {
const result = validateIconSet({
prefix: 'foo',
@ -103,11 +107,12 @@ describe('Testing validating alias', () => {
},
},
});
done(
reject(
'Expected to throw error when alias has missing parent, got ' +
JSON.stringify(result)
);
} catch (err) {
return;
} catch {
//
}
@ -138,10 +143,12 @@ describe('Testing validating alias', () => {
},
});
done();
fulfill(true);
});
});
test('Invalid parent, 2 levels', (done) => {
test('Invalid parent, 2 levels', () => {
return new Promise((fulfill, reject) => {
try {
const result = validateIconSet({
prefix: 'foo',
@ -159,11 +166,12 @@ describe('Testing validating alias', () => {
},
},
});
done(
reject(
'Expected to throw error when alias has missing parent, got ' +
JSON.stringify(result)
);
} catch (err) {
return;
} catch {
//
}
@ -197,10 +205,12 @@ describe('Testing validating alias', () => {
},
});
done();
fulfill(true);
});
});
test('Invalid parent, 2 levels, reverse order', (done) => {
test('Invalid parent, 2 levels, reverse order', () => {
return new Promise((fulfill, reject) => {
try {
const result = validateIconSet({
prefix: 'foo',
@ -218,11 +228,12 @@ describe('Testing validating alias', () => {
},
},
});
done(
reject(
'Expected to throw error when alias has missing parent, got ' +
JSON.stringify(result)
);
} catch (err) {
return;
} catch {
//
}
@ -256,10 +267,12 @@ describe('Testing validating alias', () => {
},
});
done();
fulfill(true);
});
});
test('Parent loop', (done) => {
test('Parent loop', () => {
return new Promise((fulfill, reject) => {
try {
const result = validateIconSet({
prefix: 'foo',
@ -280,11 +293,12 @@ describe('Testing validating alias', () => {
},
},
});
done(
reject(
'Expected to throw error when alias has missing parent, got ' +
JSON.stringify(result)
);
} catch (err) {
return;
} catch {
//
}
@ -326,6 +340,7 @@ describe('Testing validating alias', () => {
},
});
done();
fulfill(true);
});
});
});

112
packages/utils/tests/validate-icon-test.ts
View File

@ -54,7 +54,8 @@ describe('Testing validating icon', () => {
});
// Required string
test('body', (done) => {
test('body', () => {
return new Promise((fulfill, reject) => {
// Missing body
try {
validateIconSet({
@ -65,8 +66,9 @@ describe('Testing validating icon', () => {
},
},
});
done('Expected to throw error when body is missing');
} catch (err) {
reject('Expected to throw error when body is missing');
return;
} catch {
//
}
@ -84,10 +86,11 @@ describe('Testing validating icon', () => {
fix: true,
}
);
done(
reject(
'Expected to throw error when body is missing and cannot be fixed'
);
} catch (err) {
return;
} catch {
//
}
@ -117,11 +120,11 @@ describe('Testing validating icon', () => {
},
},
});
} catch (err) {
done(
} catch {
reject(
'Expected to not throw error when body is missing, but icon set can be fixed'
);
//
return;
}
validationValues.forEach((item, value) => {
@ -137,11 +140,15 @@ describe('Testing validating icon', () => {
});
if (item.type !== 'string') {
done(`Expected to throw error when body is ${item.text}`);
reject(
`Expected to throw error when body is ${item.text}`
);
return;
}
} catch (err) {
} catch {
if (item.type === 'string') {
done(`Expected to pass when body is ${item.text}`);
reject(`Expected to pass when body is ${item.text}`);
return;
}
}
@ -162,11 +169,15 @@ describe('Testing validating icon', () => {
);
if (item.type !== 'string') {
done(`Expected to throw error when body is ${item.text}`);
reject(
`Expected to throw error when body is ${item.text}`
);
return;
}
} catch (err) {
} catch {
if (item.type === 'string') {
done(`Expected to pass when body is ${item.text}`);
reject(`Expected to pass when body is ${item.text}`);
return;
}
}
@ -188,17 +199,20 @@ describe('Testing validating icon', () => {
fix: true,
}
);
} catch (err) {
done('Expected to pass when another icon is valid');
} catch {
reject('Expected to pass when another icon is valid');
return;
}
});
done();
fulfill(true);
});
});
// Numbers
['width', 'height', 'left', 'top', 'rotate'].forEach((prop) => {
test(prop, (done) => {
test(prop, () => {
return new Promise((fulfill, reject) => {
// Validate without fixing
validationValues.forEach((item, value) => {
try {
@ -213,13 +227,17 @@ describe('Testing validating icon', () => {
});
if (item.type !== 'number') {
done(
reject(
`Expected to throw error when ${prop} is ${item.text}`
);
return;
}
} catch (err) {
} catch {
if (item.type === 'number') {
done(`Expected to pass when ${prop} is ${item.text}`);
reject(
`Expected to pass when ${prop} is ${item.text}`
);
return;
}
}
});
@ -259,20 +277,23 @@ describe('Testing validating icon', () => {
bar: icon,
},
});
} catch (err) {
done(
} catch {
reject(
`Expected to not throw error when ${prop} is being fixed`
);
return;
}
});
done();
fulfill(true);
});
});
});
// Boolean
['hFlip', 'vFlip', 'hidden'].forEach((prop) => {
test(prop, (done) => {
test(prop, () => {
return new Promise((fulfill, reject) => {
validationValues.forEach((item, value) => {
// Validate
try {
@ -287,13 +308,17 @@ describe('Testing validating icon', () => {
});
if (item.type !== 'boolean') {
done(
reject(
`Expected to throw error when ${prop} is ${item.text}`
);
return;
}
} catch (err) {
} catch {
if (item.type === 'boolean') {
done(`Expected to pass when ${prop} is ${item.text}`);
reject(
`Expected to pass when ${prop} is ${item.text}`
);
return;
}
}
});
@ -333,19 +358,22 @@ describe('Testing validating icon', () => {
bar: icon,
},
});
} catch (err) {
done(
} catch {
reject(
`Expected to not throw error when ${prop} is being fixed`
);
return;
}
});
done();
fulfill(true);
});
});
});
// Unexpected field
test('foo', (done) => {
test('foo', () => {
return new Promise((fulfill, reject) => {
validationValues.forEach((item, value) => {
// Validate
try {
@ -360,11 +388,15 @@ describe('Testing validating icon', () => {
});
if (item.type === 'object') {
done(`Expected to throw error when value is ${item.text}`);
reject(
`Expected to throw error when value is ${item.text}`
);
return;
}
} catch (err) {
} catch {
if (item.type !== 'object') {
done(`Expected to pass when value is ${item.text}`);
reject(`Expected to pass when value is ${item.text}`);
return;
}
}
});
@ -404,11 +436,15 @@ describe('Testing validating icon', () => {
bar: icon,
},
});
} catch (err) {
done(`Expected to not throw error when value is being fixed`);
} catch {
reject(
`Expected to not throw error when value is being fixed`
);
return;
}
});
done();
fulfill(true);
});
});
});

84
packages/utils/tests/validate-test.ts
View File

@ -1,36 +1,42 @@
import { validateIconSet } from '../lib/icon-set/validate';
describe('Testing validation', () => {
test('Not object', (done) => {
test('Not object', () => {
return new Promise((fulfill, reject) => {
try {
validateIconSet(void 0);
done('Expected to throw error on undefined');
} catch (err) {
reject('Expected to throw error on undefined');
return;
} catch {
//
}
try {
validateIconSet({});
done('Expected to throw error on empty object');
} catch (err) {
reject('Expected to throw error on empty object');
return;
} catch {
//
}
try {
validateIconSet(null);
done('Expected to throw error on null');
} catch (err) {
reject('Expected to throw error on null');
return;
} catch {
//
}
try {
validateIconSet([]);
done('Expected to throw error on array');
} catch (err) {
reject('Expected to throw error on array');
return;
} catch {
//
}
done();
fulfill(true);
});
});
test('Valid set', () => {
@ -53,13 +59,15 @@ describe('Testing validation', () => {
});
});
test('Missing stuff', (done) => {
test('Missing stuff', () => {
return new Promise((fulfill, reject) => {
try {
validateIconSet({
prefix: 'foo',
});
done('Expected to throw error when icons are missing');
} catch (err) {
reject('Expected to throw error when icons are missing');
return;
} catch {
//
}
@ -68,22 +76,26 @@ describe('Testing validation', () => {
prefix: 'foo',
icons: {},
});
done('Expected to throw error when icons are empty');
} catch (err) {
reject('Expected to throw error when icons are empty');
return;
} catch {
//
}
try {
validateIconSet([]);
done('Expected to throw error on array');
} catch (err) {
reject('Expected to throw error on array');
return;
} catch {
//
}
done();
fulfill(true);
});
});
test('Characters', (done) => {
test('Characters', () => {
return new Promise((fulfill, reject) => {
// Correct icon set
expect(
validateIconSet({
@ -136,10 +148,11 @@ describe('Testing validation', () => {
e01: 'baz',
},
});
done(
reject(
'Expected to throw error when character points to missing icon'
);
} catch (err) {
return;
} catch {
//
}
@ -180,8 +193,9 @@ describe('Testing validation', () => {
test: 'bar',
},
});
done('Expected to throw error when character is invalid');
} catch (err) {
reject('Expected to throw error when character is invalid');
return;
} catch {
//
}
@ -216,10 +230,12 @@ describe('Testing validation', () => {
},
});
done();
fulfill(true);
});
});
test('Invalid default values', (done) => {
test('Invalid default values', () => {
return new Promise((fulfill, reject) => {
try {
validateIconSet(
{
@ -237,8 +253,9 @@ describe('Testing validation', () => {
},
{ fix: true }
);
done('Expected to throw error for bad default properties');
} catch (err) {
reject('Expected to throw error for bad default properties');
return;
} catch {
//
}
@ -257,8 +274,9 @@ describe('Testing validation', () => {
},
{ fix: true }
);
done('Expected to throw error for bad default properties');
} catch (err) {
reject('Expected to throw error for bad default properties');
return;
} catch {
//
}
@ -277,11 +295,13 @@ describe('Testing validation', () => {
},
{ fix: true }
);
done('Expected to throw error for bad default properties');
} catch (err) {
reject('Expected to throw error for bad default properties');
return;
} catch {
//
}
done();
fulfill(true);
});
});
});