2
0
mirror of https://github.com/iconify/iconify.git synced 2024-12-12 13:47:49 +00:00

perf: use autoInstall

This commit is contained in:
DaoYuan 2023-02-07 23:24:44 +08:00
parent b7fc04c931
commit 3107db9488
4 changed files with 11 additions and 12 deletions

View File

@ -1,5 +1,4 @@
import { promises as fs, Stats } from 'fs';
import type { IconifyLoaderOptions } from './types';
import { isPackageExists, resolveModule } from 'local-pkg';
import type { IconifyJSON } from '@iconify/types';
import { tryInstallPkg } from './install-pkg';
@ -9,7 +8,7 @@ const isLegacyExists = isPackageExists('@iconify/json');
export async function loadCollectionFromFS(
name: string,
options?: IconifyLoaderOptions
autoInstall = false
): Promise<IconifyJSON | undefined> {
if (!(await _collections[name])) {
_collections[name] = task();
@ -22,8 +21,8 @@ export async function loadCollectionFromFS(
jsonPath = resolveModule(`@iconify/json/json/${name}.json`);
}
if (!jsonPath && !isLegacyExists && options?.autoInstall) {
await tryInstallPkg(`@iconify-json/${name}`, options);
if (!jsonPath && !isLegacyExists && autoInstall) {
await tryInstallPkg(`@iconify-json/${name}`, autoInstall);
jsonPath = resolveModule(`@iconify-json/${name}/icons.json`);
}

View File

@ -2,14 +2,13 @@ import { installPackage } from '@antfu/install-pkg';
import { sleep } from '@antfu/utils';
import { cyan } from 'kolorist';
import { warnOnce } from './warn';
import type { IconifyLoaderOptions } from './types';
let pending: Promise<void> | undefined;
const tasks: Record<string, Promise<void> | undefined> = {};
export async function tryInstallPkg(
name: string,
options?: IconifyLoaderOptions
autoInstall = true
): Promise<void | undefined> {
if (pending) {
await pending;
@ -18,8 +17,8 @@ export async function tryInstallPkg(
if (!tasks[name]) {
// eslint-disable-next-line no-console
console.log(cyan(`Installing ${name}...`));
if (options?.customInstall) {
tasks[name] = pending = options
if (typeof autoInstall === 'function') {
tasks[name] = pending = autoInstall
.customInstall(name)
.then(() => sleep(300))
.finally(() => {

View File

@ -14,7 +14,10 @@ export const loadNodeIcon: UniversalIconLoader = async (
return result;
}
const iconSet = await loadCollectionFromFS(collection, options);
const iconSet = await loadCollectionFromFS(
collection,
options?.autoInstall
);
if (iconSet) {
// possible icon names
const ids = [

View File

@ -154,9 +154,7 @@ export type IconifyLoaderOptions = {
*
* @default false
*/
autoInstall?: boolean;
customInstall?: (name: string) => Promise<void | undefined>;
autoInstall?: boolean | ((name: string) => Promise<void | undefined>);
/**
* The additional icon properties applied to the svg.
*