agerix/iconify
2
0
Fork 0
mirror of https://github.com/iconify/iconify.git synced 2025-01-07 07:34:22 +00:00
Code Issues Releases Activity

Minor optimisations in core package to reduce bundle size

Browse Source
This commit is contained in:
Vjacheslav Trushkin 2022-07-02 18:19:41 +03:00
parent 40ba4e076a
commit 696a5514e2
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/icon/list.ts
View File

@ -15,7 +15,7 @@ export function listToIcons(
const icon =
typeof item === 'string'
? (stringToIcon(item, validate, simpleNames) as IconifyIconName)
: { ...item };
: item;
if (icon) {
result.push(icon);
}

14
packages/core/src/storage/functions.ts
View File

@ -95,15 +95,11 @@ export function addCollection(data: IconifyJSON, provider?: string): boolean {
// Get provider
if (typeof provider !== 'string') {
provider = typeof data.provider === 'string' ? data.provider : '';
provider = data.provider || '';
}
// Check for simple names: requires empty provider and prefix
if (
simpleNames &&
provider === '' &&
(typeof data.prefix !== 'string' || data.prefix === '')
) {
if (simpleNames && !provider && !data.prefix) {
// Simple names: add icons one by one
let added = false;
@ -121,18 +117,18 @@ export function addCollection(data: IconifyJSON, provider?: string): boolean {
}
// Validate provider and prefix
const prefix = data.prefix;
if (
typeof data.prefix !== 'string' ||
!validateIconName({
provider,
prefix: data.prefix,
prefix,
name: 'a',
})
) {
return false;
}
const storage = getStorage(provider, data.prefix);
const storage = getStorage(provider, prefix);
return !!addIconSet(storage, data);
}