agerix/iconify
2
0
Fork 0
mirror of https://github.com/iconify/iconify.git synced 2024-09-19 00:39:02 +00:00
Code Issues Releases Activity

Remove shareStorage function - no longer needed because web component reuses same class even if bundled multiple times

Browse Source
This commit is contained in:
Vjacheslav Trushkin 2022-05-21 22:55:01 +03:00
parent 390fac8759
commit a64b9a78ff
15 changed files with 16 additions and 76 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
components/ember/src/iconify-icon.ts
View File

@ -11,7 +11,7 @@ import {
addCollection,
allowSimpleNames,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -228,7 +228,7 @@ export { _api };
export { addAPIProvider, loadIcons, loadIcon };
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

4
components/react/src/iconify.ts
View File

@ -14,7 +14,7 @@ import {
getIconData,
allowSimpleNames,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -464,7 +464,7 @@ export { _api };
export { addAPIProvider, loadIcons, loadIcon };
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

2
components/svelte/src/Icon.svelte
View File

@ -8,7 +8,6 @@ import {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,
@ -26,7 +25,6 @@ export {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,

4
components/svelte/src/functions.ts
View File

@ -13,7 +13,7 @@ import {
getIconData,
allowSimpleNames,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -358,7 +358,7 @@ export { _api };
export { addAPIProvider, loadIcons, loadIcon };
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

1
components/svelte/src/iconify.ts
View File

@ -55,7 +55,6 @@ export {
listIcons,
addIcon,
addCollection,
shareStorage,
} from './functions';
export { calculateSize, replaceIDs, buildIcon } from './functions';

5
components/svg-framework/src/iconify.ts
View File

@ -13,7 +13,7 @@ import {
addIcon,
addCollection,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -213,7 +213,6 @@ const Iconify: IconifyGlobal = {
listIcons,
addIcon,
addCollection,
shareStorage,
// IconifyBuilderFunctions
replaceIDs,
@ -251,7 +250,7 @@ export { _api };
export { addAPIProvider, loadIcons, loadIcon };
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

5
components/svg-framework/src/iconify.without-api.ts
View File

@ -13,7 +13,7 @@ import {
addIcon,
addCollection,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -63,7 +63,6 @@ const Iconify: IconifyGlobal = {
listIcons,
addIcon,
addCollection,
shareStorage,
// IconifyBuilderFunctions
replaceIDs,
@ -91,7 +90,7 @@ export default Iconify;
* Named exports
*/
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

4
components/vue/src/iconify.ts
View File

@ -23,7 +23,7 @@ import {
getIconData,
allowSimpleNames,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -404,7 +404,7 @@ export { _api };
export { addAPIProvider, loadIcons, loadIcon };
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

4
components/vue2/src/iconify.ts
View File

@ -16,7 +16,7 @@ import {
getIconData,
allowSimpleNames,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { replaceIDs } from '@iconify/utils/lib/svg/id';
@ -386,7 +386,7 @@ export { _api };
export { addAPIProvider, loadIcons, loadIcon };
// IconifyStorageFunctions
export { iconExists, getIcon, listIcons, addIcon, addCollection, shareStorage };
export { iconExists, getIcon, listIcons, addIcon, addCollection };
// IconifyBuilderFunctions
export { replaceIDs, calculateSize, buildIcon };

3
iconify-icon/icon/src/functions.ts
View File

@ -11,7 +11,7 @@ import {
addIcon,
addCollection,
} from '@iconify/core/lib/storage/functions';
import { listIcons, shareStorage } from '@iconify/core/lib/storage/storage';
import { listIcons } from '@iconify/core/lib/storage/storage';
import type { IconifyBuilderFunctions } from '@iconify/core/lib/builder/functions';
import { buildIcon } from '@iconify/core/lib/builder/functions';
import { calculateSize } from '@iconify/utils/lib/svg/size';
@ -159,7 +159,6 @@ export function exportFunctions(): IconifyExportedFunctions {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,

2
iconify-icon/icon/src/index.ts
View File

@ -112,7 +112,6 @@ const {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,
@ -129,7 +128,6 @@ export {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,

1
iconify-icon/react/src/iconify.ts
View File

@ -60,7 +60,6 @@ export {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,

1
iconify-icon/solid/src/iconify.tsx
View File

@ -61,7 +61,6 @@ export {
iconExists,
getIcon,
listIcons,
shareStorage,
addIcon,
addCollection,
calculateSize,

9
packages/core/src/storage/functions.ts
View File

@ -35,15 +35,6 @@ export interface IconifyStorageFunctions {
* Add icon set to storage
*/
addCollection: (data: IconifyJSON, provider?: string) => boolean;
/**
* Share storage (used to share icon data between various components or multiple instances of component)
*
* It works by moving storage to global variable, new instances of component attempt to detect global
* variable during load. Therefore, function should be called as soon as possible.
* Works only in browser, not usable in SSR.
*/
shareStorage: () => void;
}
/**

43
packages/core/src/storage/storage.ts
View File

@ -19,55 +19,14 @@ export interface IconStorage {
missing: Record<string, number>;
}
/**
* Storage format version
*/
const storageVersion = 1;
/**
* Storage by provider and prefix
*/
let storage = Object.create(null) as Record<
const storage = Object.create(null) as Record<
string,
Record<string, IconStorage>
>;
/**
* Share storage
*/
interface WindowWithStorage extends Window {
_iconifyStorage: {
version: number;
storage: Record<string, Record<string, IconStorage>>;
};
}
try {
const w = (window || self) as unknown as WindowWithStorage | undefined;
if (w && w._iconifyStorage.version === storageVersion) {
storage = w._iconifyStorage.storage;
}
} catch (err) {
//
}
/**
* Share storage between components
*/
export function shareStorage(): void {
try {
const w = (window || self) as unknown as WindowWithStorage | undefined;
if (w && !w._iconifyStorage) {
w._iconifyStorage = {
version: storageVersion,
storage,
};
}
} catch (err) {
//
}
}
/**
* Create new storage
*/