2
0
mirror of https://github.com/iconify/iconify.git synced 2025-01-12 01:45:41 +00:00

Refactoring React: full component, without automatic data loading yet

This commit is contained in:
Vjacheslav Trushkin 2021-04-26 21:43:20 +03:00
parent 31ceb48b6e
commit e1fa93db6b
19 changed files with 153 additions and 26 deletions

View File

@ -186,19 +186,23 @@ allowSimpleNames(true);
// Set API
coreModules.api = API;
let getAPIModule: GetIconifyAPIModule;
// Use Fetch API by default
let getAPIModule: GetIconifyAPIModule = getFetchAPIModule;
try {
getAPIModule =
typeof fetch === 'function' && typeof Promise === 'function'
? getFetchAPIModule
: getJSONPAPIModule;
if (typeof document !== 'undefined' && typeof window !== 'undefined') {
// If window and document exist, attempt to load whatever module is available, otherwise use Fetch API
getAPIModule =
typeof fetch === 'function' && typeof Promise === 'function'
? getFetchAPIModule
: getJSONPAPIModule;
}
} catch (err) {
getAPIModule = getJSONPAPIModule;
//
}
setAPIModule('', getAPIModule(getAPIConfig));
/**
* Enable node-fetch for getting icons on server side
* Function to enable node-fetch for getting icons on server side
*/
export function setNodeFetch(nodeFetch: typeof fetch) {
setFetch(nodeFetch);
@ -288,10 +292,6 @@ if (typeof document !== 'undefined' && typeof window !== 'undefined') {
/**
* Component
*/
/**
* Generate icon
*/
function component(
props: IconProps,
inline: boolean,

View File

@ -0,0 +1,40 @@
import { loadIcons, iconExists } from '../../lib/iconify';
import { mockAPIData } from '@iconify/core/lib/api/modules/mock';
import { provider, nextPrefix } from './load';
describe('Testing fake API', () => {
test('using fake API to load icon', (done) => {
const prefix = nextPrefix();
const name = 'mock-test';
const iconName = `@${provider}:${prefix}:${name}`;
mockAPIData({
provider,
prefix,
response: {
prefix,
icons: {
[name]: {
body: '<g />',
},
},
},
});
// Check if icon has been loaded
expect(iconExists(iconName)).toEqual(false);
// Load icon
loadIcons([iconName], (loaded, missing, pending) => {
expect(loaded).toMatchObject([
{
provider,
prefix,
name,
},
]);
expect(missing).toMatchObject([]);
expect(pending).toMatchObject([]);
done();
});
});
});

View File

@ -0,0 +1,72 @@
import React from 'react';
import { Icon, loadIcons, iconExists } from '../../lib/iconify';
import { mockAPIData } from '@iconify/core/lib/api/modules/mock';
import { provider, nextPrefix } from './load';
const iconData = {
body:
'<path d="M4 19h16v2H4zm5-4h11v2H9zm-5-4h16v2H4zm0-8h16v2H4zm5 4h11v2H9z" fill="currentColor"/>',
width: 24,
height: 24,
};
describe('Rendering icon', () => {
test('rendering icon after loading it', (done) => {
const prefix = nextPrefix();
const name = 'mock-test';
const iconName = `@${provider}:${prefix}:${name}`;
mockAPIData({
provider,
prefix,
response: {
prefix,
icons: {
[name]: iconData,
},
},
});
// Check if icon has been loaded
expect(iconExists(iconName)).toEqual(false);
// Load icon
loadIcons([iconName], (loaded, missing, pending) => {
// Make sure icon has been loaded
expect(loaded).toMatchObject([
{
provider,
prefix,
name,
},
]);
expect(missing).toMatchObject([]);
expect(pending).toMatchObject([]);
expect(iconExists(iconName)).toEqual(true);
// Render component
const component = renderer.create(<Icon icon={iconName} />);
const tree = component.toJSON();
expect(tree).toMatchObject({
type: 'svg',
props: {
'xmlns': 'http://www.w3.org/2000/svg',
'xmlnsXlink': 'http://www.w3.org/1999/xlink',
'aria-hidden': true,
'role': 'img',
'style': {},
'dangerouslySetInnerHTML': {
__html: iconData.body,
},
'width': '1em',
'height': '1em',
'preserveAspectRatio': 'xMidYMid meet',
'viewBox': '0 0 ' + iconData.width + ' ' + iconData.height,
},
children: null,
});
done();
});
});
});

View File

@ -0,0 +1,15 @@
import { _api, addAPIProvider } from '../../lib/iconify';
import { mockAPIModule } from '@iconify/core/lib/api/modules/mock';
// API provider for tests
export const provider = 'mock-api';
// Set API module for provider
addAPIProvider(provider, {
resources: 'http://localhost',
});
_api.setAPIModule(provider, mockAPIModule);
// Prefix
let counter = 0;
export const nextPrefix = () => 'mock-' + counter++;

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon, InlineIcon } from '../../dist/iconify';
import { Icon, InlineIcon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon } from '../../dist/iconify';
import { Icon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
describe('Empty icon', () => {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon, InlineIcon } from '../../dist/iconify';
import { Icon, InlineIcon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { InlineIcon } from '../../dist/iconify';
import { InlineIcon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon } from '../../dist/iconify';
import { Icon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
const iconDataWithID = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon } from '../../dist/iconify';
import { Icon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { InlineIcon } from '../../dist/iconify';
import { InlineIcon } from '../../lib/iconify';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon, InlineIcon } from '../../dist/offline';
import { Icon, InlineIcon } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon } from '../../dist/offline';
import { Icon } from '../../lib/offline';
import renderer from 'react-test-renderer';
describe('Empty icon', () => {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon, InlineIcon } from '../../dist/offline';
import { Icon, InlineIcon } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { InlineIcon } from '../../dist/offline';
import { InlineIcon } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon } from '../../dist/offline';
import { Icon } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconDataWithID = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon } from '../../dist/offline';
import { Icon } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { Icon, addIcon, addCollection } from '../../dist/offline';
import { Icon, addIcon, addCollection } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconData = {

View File

@ -1,5 +1,5 @@
import React from 'react';
import { InlineIcon } from '../../dist/offline';
import { InlineIcon } from '../../lib/offline';
import renderer from 'react-test-renderer';
const iconData = {