agerix/jQuery-Autocomplete
2
0
Fork 0
mirror of https://github.com/devbridge/jQuery-Autocomplete.git synced 2024-11-25 14:17:45 +00:00
Code Issues Releases Activity

Fix an issue with arrow selection of elements with top orientation

Browse Source 
If the orientation of the dropdown is `top`, the user could not hit the up arrow
to select an element in the dropdown.
This commit is contained in:
Dan Schultz 2014-08-11 10:30:59 -07:00
parent a9e79277fb
commit b06f53edc6
1 changed files with 39 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/jquery.autocomplete.js
View File

@ -132,6 +132,8 @@
killerFn: null,
displayedOrientation: null,
initialize: function () {
var that = this,
suggestionSelector = '.' + that.classes.suggestion,
@ -284,10 +286,12 @@
orientation = 'bottom';
}
if (orientation === 'top')
if (orientation === 'top')
styles.top += -containerHeight;
else
styles.top += height;
else
styles.top += height;
that.displayedOrientation = orientation;
// If container is not positioned to body,
// correct its position using offset parent offset
@ -788,16 +792,27 @@
moveUp: function () {
var that = this;
if (that.selectedIndex === -1) {
return;
}
if (that.displayedOrientation === 'bottom') {
if (that.selectedIndex === -1) {
return;
}
if (that.selectedIndex === 0) {
$(that.suggestionsContainer).children().first().removeClass(that.classes.selected);
that.selectedIndex = -1;
that.el.val(that.currentValue);
that.findBestHint();
return;
if (that.selectedIndex === 0) {
$(that.suggestionsContainer).children().first().removeClass(that.classes.selected);
that.selectedIndex = -1;
that.el.val(that.currentValue);
that.findBestHint();
return;
}
} else {
if (that.selectedIndex === -1) {
that.adjustScroll(that.suggestions.length - 1);
return;
}
if (that.selectedIndex === 0) {
return;
}
}
that.adjustScroll(that.selectedIndex - 1);
@ -806,8 +821,18 @@
moveDown: function () {
var that = this;
if (that.selectedIndex === (that.suggestions.length - 1)) {
return;
if (that.displayedOrientation === 'bottom') {
if (that.selectedIndex === (that.suggestions.length - 1)) {
return;
}
} else {
if (that.selectedIndex == -1) {
return;
}
if (that.selectedIndex > (that.suggestions.length - 1)) {
return;
}
}
that.adjustScroll(that.selectedIndex + 1);