christianlight
/
tutor
mirror of https://github.com/ChristianLight/tutor.git
7
0
Fork 0
Code Issues Releases Activity
tutor/tests/test_images.py

15 lines
472 B
Python
Raw Normal View History

Better `dev` environment The `dev` commands now rely on a different openedx-dev docker image. This gives us multiple improvements: - no more chown in base image - faster chown in development - mounted requirements volume in development - fix static assets issues - bundled ipdb/vim/... packages, which are convenient for development Close #235
2019-10-22 14:13:50 +00:00
import unittest
refactor: add code coverage, cover CLI commands with tests
2021-11-23 08:25:09 +00:00
Better `dev` environment The `dev` commands now rely on a different openedx-dev docker image. This gives us multiple improvements: - no more chown in base image - faster chown in development - mounted requirements volume in development - fix static assets issues - bundled ipdb/vim/... packages, which are convenient for development Close #235
2019-10-22 14:13:50 +00:00
from tutor import images
refactor: better config type checking I stumbled upon a bug that should have been detected by the type checking. Turns out, considering that config is of type Dict[str, Any] means that we can use just any method on all config values -- which is terrible. I discovered this after I set `config["PLUGINS"] = None`: this triggered a crash when I enabled a plugin. We resolve this by making the Config type more explicit. We also take the opportunity to remove a few cast statements.
2021-04-06 10:09:00 +00:00
from tutor.types import Config
Better `dev` environment The `dev` commands now rely on a different openedx-dev docker image. This gives us multiple improvements: - no more chown in base image - faster chown in development - mounted requirements volume in development - fix static assets issues - bundled ipdb/vim/... packages, which are convenient for development Close #235
2019-10-22 14:13:50 +00:00
class ImagesTests(unittest.TestCase):
refactor: add type annotations Annotations were generated with pyannotate: https://github.com/dropbox/pyannotate We are running in strict mode, which is awesome! This affects a large part of the code base, which might be an issue for people running a fork of Tutor. Nonetheless, the behavior should not be affected. If anything, this process has helped find and resolve a few type-related bugs. Thus, this is not considered as a breaking change.
2021-02-25 08:09:14 +00:00
def test_get_tag(self) -> None:
refactor: better config type checking I stumbled upon a bug that should have been detected by the type checking. Turns out, considering that config is of type Dict[str, Any] means that we can use just any method on all config values -- which is terrible. I discovered this after I set `config["PLUGINS"] = None`: this triggered a crash when I enabled a plugin. We resolve this by making the Config type more explicit. We also take the opportunity to remove a few cast statements.
2021-04-06 10:09:00 +00:00
config: Config = {
Fix `images.get_tag` unit test
2020-07-21 07:28:21 +00:00
"DOCKER_IMAGE_OPENEDX": "registry/openedx",
"DOCKER_IMAGE_OPENEDX_DEV": "registry/openedxdev",
Better `dev` environment The `dev` commands now rely on a different openedx-dev docker image. This gives us multiple improvements: - no more chown in base image - faster chown in development - mounted requirements volume in development - fix static assets issues - bundled ipdb/vim/... packages, which are convenient for development Close #235
2019-10-22 14:13:50 +00:00
}
self.assertEqual("registry/openedx", images.get_tag(config, "openedx"))
self.assertEqual("registry/openedxdev", images.get_tag(config, "openedx-dev"))